Add contract market tests #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixlettervariables
requested review from
neoancient,
NickAragua and
Windchild292
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
============================================
+ Coverage 8.35% 10.28% +1.92%
- Complexity 2601 3408 +807
============================================
Files 672 674 +2
Lines 95008 94902 -106
Branches 15965 15933 -32
============================================
+ Hits 7934 9756 +1822
+ Misses 86008 83776 -2232
- Partials 1066 1370 +304
Continue to review full report at Codecov.
|
sixlettervariables
force-pushed
the
add-contract-market-tests
branch
from
1d8dff2 to
a927036
Compare
|
Looks like by removing the incidental thread load of Systems I decreased coverage in tests that never really used it anyways. I'll add a test to load the data and check it. |
- Likewise rename Factions::generate to loadDefault and load
sixlettervariables
added
the
Tests
Windchild292
approved these changes
Dec 29, 2020
MekHQ/unittests/mekhq/campaign/market/ContractMarketIntegrationTest.java
Show resolved
Hide resolved
MekHQ/unittests/mekhq/campaign/market/ContractMarketAtBGenerationTests.java
Show resolved
Hide resolved
MekHQ/unittests/mekhq/campaign/market/ContractMarketAtBGenerationTests.java
Outdated
Show resolved
Hide resolved
MekHQ/unittests/mekhq/campaign/market/ContractMarketAtBGenerationTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic contract market tests to avoid situations like #2283 in the future.
In order to accomplish this I needed to do four things first:
Systems::setInstanceto let me mock static usages ofSystems.getInstance()RandomFactionGenerator::setInstanceto let me mock static usages ofRandomFactionGenerator::getInstance()FactionintoFactionsand make them instance methodsFactions::getInstance(), andFactions::setInstanceto let me mock the previously static methodsThat commit is acb530c
The subsequent commits all make use of that work to add basic tests for the
ContractMarket.