47.15 Contracts Cannot Be Generated

[jschmetzer]

Environment

47.15
Java version 1.8.0_251
Platform Mac OS X 10.16 (x86_64)
Total memory available to MegaMek: 1,864,192 kB

Fresh campaign, 3030, on Galatea, stock AtB Default campaign presets.

1. No contracts available on campaign first load.
2. GM Generate yields error: Unable to GM-generate contract from the current location. Increase contract search radius or travel to a border world for better odds of success.
3. Log shows recurrent: WARN [mekhq.campaign.market.ContractMarket] {AWT-EventQueue-0}
   generateAtBContract(), line 323 : Could not generate an AtB Contract because we ran out of retries!

contract_gen_fail.zip
cpnx, logs attached

[NickAragua]

Confirmed, I've encountered this as well in my campaign.

[sixlettervariables]

Were there other warnings? Usually it spits out a Why it had to retry.

[NickAragua]

Nope, nothing else.

[sixlettervariables]

FFS:

mekhq/MekHQ/src/mekhq/campaign/market/ContractMarket.java

Lines 301 to 302 in 3d6f5a5

	retVal = generateAtBContract(campaign, RandomFactionGenerator.getInstance().getEmployer(),
	unitRatingMod, 0);

If you pass 0, you get 0.

[NickAragua]

Heh, doesn't leave much room for a workaround.

[sixlettervariables]

Yeah didn't see this bug in my last push to fix before RC1.