Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palm minor version upgrade and fixes #43

Merged
merged 25 commits into from
Feb 2, 2024
Merged

Conversation

tramck
Copy link

@tramck tramck commented Feb 2, 2024

No description provided.

DmytroAlipov and others added 24 commits May 15, 2023 13:05
Fixed the Course Card Image is absent on FB post
after sharing by user. Commit for Palm release.
…a256` (openedx#33345)

---------

Co-authored-by: Muhammad Soban Javed <[email protected]>
Co-authored-by: Robert Raposa <[email protected]>
Co-authored-by: Muhammad Soban Javed <[email protected]>
…t-palm

fix: User retirement 404 for state RETIRING_FORUMS
[Palm-Backport] Update DEFAULT_HASHING_ALGORITHM to sha256
@tramck tramck requested a review from jcohen28 February 2, 2024 14:22
Copy link
Member

@jcohen28 jcohen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment below. Have you confirmed that any recent changes (such as Patrick's) to medality-olive have been pulled in?

@@ -846,8 +847,13 @@ def is_enrolled(cls, user, course_key):

`course_id` is our usual course_id string (e.g. "edX/Test101/2013_Fall)
"""
enrollment_state = cls._get_enrollment_state(user, course_key)
return enrollment_state.is_active or False
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we tag this with @medality_custom?

@tramck
Copy link
Author

tramck commented Feb 2, 2024

@jcohen28 added the medality_custom tag and confirmed this branch is up to date with medality-olive!

@tramck tramck merged commit 0e4122f into medality-palm Feb 2, 2024
33 of 40 checks passed
@tramck tramck deleted the _medality-palm-travis branch February 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants