propagate override

[pbischof42]

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

• Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
  "Developer", and "Operator".
• Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
• Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
  changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
• If your database migration can't be rolled back easily.

[jcohen28]

nit: spacing

Suggested change

	_propagate_library_updates(xblock.location.course_key,user.id)
	_propagate_library_updates(xblock.location.course_key, user.id)

[ianj-lewis]

An alternative to creating a separate function here is to override _save_xblock, get its return value in the override function via the prev_fn arg, and perform the required logic there prior to returning:

def override_save_xblock(_save_xblock, *args, **kwargs):
    response = _save_xblock(*args, **kwargs)
    # Your logic here
    return response

This way we only need to include one line of changes in the edx repo, @pluggable_override("OVERRIDE_SAVE_XBLOCK"). Although on the other hand, defining a custom function tamps down on the scope of what we're overriding / allows us to handle only the arguments we need. @tramck do you have an opinion?

https://github.com/openedx/edx-django-utils/blob/2c975229cbbbfc07f3320b72cbb91f208957f2f5/edx_django_utils/plugins/pluggable_override.py#L26-L28

[ianj-lewis]

Pluggable override names should always be prefixed with OVERRIDE_

Suggested change

	@pluggable_override("PROPAGATE_LIBRARY_UPDATES")
	@pluggable_override("OVERRIDE_PROPAGATE_LIBRARY_UPDATES")

[ianj-lewis]

Anytime we're making changes to the edx repo, we should include a @medality_custom comment so we can easily find where we've made our own modifications, here's an example:

edx-platform/lms/djangoapps/course_blocks/transformers/library_content.py

Lines 27 to 43 in 4ac6887

	# @medality_custom: start
	def is_library_block(block_key):
	return block_key.block_type in ["library_content", "select_from_library"]
	def get_xblock_class(block_type):
	"""
	Returns the class associated to the entry point of the given block type
	"""
	group = "xblock.v1"
	for entry_point in pkg_resources.iter_entry_points(group):
	if entry_point.name == block_type:
	return pkg_resources.load_entry_point(entry_point.dist, group, block_type)
	return None
	# @medality_custom: end