Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 2.28: Remove unneeded setting of ret from ssl programs #8218

Conversation

paul-elliott-arm
Copy link
Member

@paul-elliott-arm paul-elliott-arm commented Sep 15, 2023

Description

Remove coverity warnings on unused values. Trivial backport of #8217

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided, or not required (minor change in example programs)
  • backport done, or not required~~ (This is the backport)
  • tests provided, or not required (minor change in programs)

Remove a coverity warning on unused values.

Signed-off-by: Paul Elliott <[email protected]>
@paul-elliott-arm paul-elliott-arm self-assigned this Sep 15, 2023
@paul-elliott-arm paul-elliott-arm changed the base branch from development to mbedtls-2.28 September 15, 2023 16:48
@paul-elliott-arm paul-elliott-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review single-reviewer This PR qualifies for having only one reviewer priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Sep 15, 2023
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same meh as the original

@gilles-peskine-arm gilles-peskine-arm changed the title Remove unused values programs 2 28 Backport 2.28: Remove unneeded setting of ret from ssl programs Sep 15, 2023
@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 15, 2023
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Sep 18, 2023
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 433aa1c Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants