Remove unneeded setting of ret from ssl programs #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove coverity warnings on unused values. Signed-off-by: Paul Elliott <[email protected]>
paul-elliott-arm
added
enhancement
needs-review
gilles-peskine-arm
approved these changes
Sep 15, 2023
3 tasks
| @@ -3781,7 +3781,6 @@ int main(int argc, char *argv[]) | |||
| switch (ret) { | |||
| case MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY: | |||
| mbedtls_printf(" connection was closed gracefully\n"); | |||
| ret = 0; | |||
| goto close_notify; | |||
There was a problem hiding this comment.
This is a jump over 300 lines!!
There was a problem hiding this comment.
Many sample programs, and even more the SSL test programs, could use some restructuring. But it's nowhere near the top of my priorities for technical debt resumption.
tom-cosgrove-arm
approved these changes
Sep 15, 2023
tom-cosgrove-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove coverity warnings on unused values.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
provided, ornot required (minor change in example programs), or not required(Backport 2.28: Remove unneeded setting of ret from ssl programs #8218 )provided, ornot required (minor change in programs)