Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix all.sh --force #6309

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Backport 2.28: Fix all.sh --force #6309

merged 2 commits into from
Sep 23, 2022

Conversation

gilles-peskine-arm
Copy link
Contributor

Trivial backport of #6248

@gilles-peskine-arm
Don't try restoring a file if no backup is available
423dd13 
This caused `all.sh --force` to fail on a clean build tree.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm
Don't remove programs/fuzz/Makefile
7959858 
Other programs/*/Makefile are only created by CMake, but programs/fuzz has
its own Makefile in the repository. Fixes Mbed-TLS#6247.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review component-test Test framework and CI scripts labels Sep 22, 2022
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 22, 2022
Merged
davidhorstmann-arm
davidhorstmann-arm approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhorstmann-arm
Copy link
Contributor

Looks like a trivial enough backport for single-reviewer unless you disagree.

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 22, 2022
@gilles-peskine-arm gilles-peskine-arm merged commit 662b301 into Mbed-TLS:mbedtls-2.28 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-test Test framework and CI scripts single-reviewer This PR qualifies for having only one reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilles-peskine-arm @davidhorstmann-arm