Fix all.sh --force #6248
Merged
Fix all.sh --force #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused `all.sh --force` to fail on a clean build tree. Signed-off-by: Gilles Peskine <[email protected]>
Other programs/*/Makefile are only created by CMake, but programs/fuzz has its own Makefile in the repository. Fixes Mbed-TLS#6247. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
AndrzejKurek
approved these changes
Aug 31, 2022
davidhorstmann-arm
approved these changes
Sep 9, 2022
| @@ -295,7 +298,7 @@ cleanup() | |||
| -iname CMakeCache.txt -o \ | |||
| -path './cmake/*.cmake' \) -exec rm -f {} \+ | |||
| # Recover files overwritten by in-tree CMake builds | |||
There was a problem hiding this comment.
Not a blocker but it would seem good to add a comment here explaining that fuzz has a checked-in Makefile not generated by CMake (it's not obvious precisely why we skip this directory).
davidhorstmann-arm
removed
needs-review
AndrzejKurek
added
the
approved
|
@gilles-peskine-arm Just a gentle remainder that this is waiting for a backport, but would be ready for merge otherwise. |
gilles-peskine-arm
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6247
Backport: #6309