[Backport 2.28]Crash in test suite x509write config full no seedfile #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_x509write_csr_free() will crash if uninitialized When USE_PSA_INIT() failed because lack of seedfile, mbedtls_x509write_csr_free() crashed when called on an unitialized mbedtls_x509write_csr struct. This moves mbedtls_x509write_csr_init before calling USE_PSA_INIT(), which could probably fail, and uses the same flow in x509_csr_check() and x509_csr_check_opaque(). Signed-off-by: Neil Armstrong <[email protected]>
1 task
mpg
added
single-reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #6109:
Steps to reproduce:
Observed behaviour: the first few tests fail, then eventually there's a bus error and a core dump is produced. If we just add the seedfile again (
dd if=/dev/urandom of=./tests/seedfile bs=64 count=1) everything passes and there is no crash.Cause:
When USE_PSA_INIT() failed because lack of seedfile,
mbedtls_x509write_csr_free()crashed when called on an unitialized
mbedtls_x509write_csrstruct.This moves
mbedtls_x509write_csr_initbefore calling USE_PSA_INIT(),which could probably fail, and use the same flow in
x509_csr_check()and
x509_csr_check_opaque().Status
READY
Requires Backporting
NO
Migrations
NO
Additional comments
N/A