Crash in test suite x509write config full no seedfile #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superna9999
force-pushed
the
6100-crash-in-test-suite-x509write
branch
from
4c68188 to
e607a74
Compare
superna9999
added
bug
needs-review
mpg
previously approved these changes
Jul 28, 2022
|
Aw, this now has a conflict and will need to be rebased when you come back. |
|
Note: I think this should be backported to 2.28, but does not deserve a ChangeLog entry, as the bug is only in test code. |
mpg
added
the
needs-backports
Zaya-dyno
previously approved these changes
Jul 28, 2022
|
This one needs to be rebased. |
…s_x509write_csr_free() will crash if uninitialized When USE_PSA_INIT() failed because lack of seedfile, mbedtls_x509write_csr_free() crashed when called on an unitialized mbedtls_x509write_csr struct. This moves mbedtls_x509write_csr_init before calling USE_PSA_INIT(), which could probably fail, and uses the same flow in x509_csr_check() and x509_csr_check_opaque(). Signed-off-by: Neil Armstrong <[email protected]>
superna9999
force-pushed
the
6100-crash-in-test-suite-x509write
branch
from
e607a74 to
a97f1ac
Compare
|
Rebased on |
daverodgman
removed
the
needs-reviewer
mpg
removed
the
needs-review
mpg
added
the
approved
|
@superna9999 Please create a backport to 2.28 so that we can merge this. |
mpg
removed
the
needs-backports
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps to reproduce:
Observed behaviour: the first few tests fail, then eventually there's a bus error and a core dump is produced. If we just add the seedfile again (
dd if=/dev/urandom of=./tests/seedfile bs=64 count=1) everything passes and there is no crash.Cause:
When USE_PSA_INIT() failed because lack of seedfile,
mbedtls_x509write_csr_free()crashed when called on an unitialized
mbedtls_x509write_csrstruct.This moves
mbedtls_x509write_csr_initbefore calling USE_PSA_INIT(),which could probably fail, and use the same flow in
x509_csr_check()and
x509_csr_check_opaque().Resolves #6100
Gatekeeping note: I (mpg) think this should be backported to 2.28, but does not deserve a ChangeLog entry, as the bug is only in test code.
Status
READY
Requires Backporting
Yes 2.28 #6246
Migrations
NO
Additional comments
N/A
Todos
Steps to test or reproduce
test_suite_x509write must not crash without a seedfile