[Backport 2.16] NetBSD/OpenBSD symbol availability fix #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gufe44
changed the title
Signed-off-by: gufe44 <[email protected]>
daverodgman
added
needs-ci
yanesca
added
Community
needs-reviewer
gilles-peskine-arm
requested changes
Oct 13, 2020
There was a problem hiding this comment.
As in #3656 (comment): _xxx_SOURCE should not be redefined if it's already defined.
gilles-peskine-arm
added
needs-work
and removed
needs-review
|
Unfortunately, for personal reasons I won't be able to continue to work on the PR. You can close the PR now and resurrect the branch at any time. |
gilles-peskine-arm
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #3571.
Edit: added OpenBSD counterpart (see stdlib.h#L316-L319 and cdefs.h#L392-L395)