Allow builds with -std=c99 on LTS branch 2.7 #3656
Conversation
daverodgman
added
the
needs-review
tests/suites/main_test.function
Outdated
| if( unmet_dependencies[unmet_dep_count] == NULL ) | ||
| { | ||
| mbedtls_fprintf( stderr, | ||
| "FATAL: Out of memory\n" ); | ||
| mbedtls_exit( MBEDTLS_EXIT_FAILURE ); | ||
| } | ||
| for( j = 0; j < len; j++ ) | ||
| { |
There was a problem hiding this comment.
It would be simpler to call strncpy here
daverodgman
added
needs-work
and removed
needs-review
Signed-off-by: gufe44 <[email protected]>
Do this by including strings.h and defining feature test macros _POSIX_C_SOURCE, _XOPEN_SOURCE, _GNU_SOURCE, _BSD_SOURCE and _NETBSD_SOURCE Signed-off-by: gufe44 <[email protected]>
Signed-off-by: gufe44 <[email protected]>
daverodgman
added
needs-review
There was a problem hiding this comment.
The changes are ok, except that the _xxx_SOURCE macros should only be defined if they aren't already defined.
Please add -std=c99 -pedantic to test_build_opt in all.sh, as is already the case in mbedtls-2.16 and development, to avoid future regressions.
| @@ -44,6 +44,11 @@ | |||
| * ********** | |||
| */ | |||
|
|
|||
| #if defined(__linux__) | |||
| /* Ensure that syscall() is available even when compiling with -std=c99 */ | |||
| #define _GNU_SOURCE | |||
There was a problem hiding this comment.
As reported in #3432, _GNU_SOURCE should not be redefined if it's already defined.
This also applies to _POSIX_C_SOURCE, _XOPEN_SOURCE and any similar macro.
gilles-peskine-arm
added
component-platform
|
Unfortunately, for personal reasons I won't be able to continue to work on the PR. You can close the PR now and resurrect the branch at any time. |
There was a problem hiding this comment.
As with #3658 (review), I don't think these changes are correct, because they require a more recent POSIX version than what the long-time-support branch originally required.
|
I agree with the above. This is being closed as these changes would not be compatible with older systems on the LTS. |
Includes (partial) backports of #1198, #3190, #3421, #3422 and #3571.