Fix failure detection and failures in basic-build-test.sh with SSL3 in basic-build-test #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
force-pushed
the
basic-build-test-status-with-deprecated
branch
from
49162f3 to
1de46d8
Compare
mpg
requested changes
Apr 10, 2020
| } | tee tests/cov-$TEST_OUTPUT | ||
|
|
||
| if [ "$(tail -n1 tests/cov-$TEST_OUTPUT)" != "SUCCESS" ]; then | ||
| echo >&2 "Fatal: 'make lcov' failed" |
There was a problem hiding this comment.
The commit message says "exit immediately" but I'm not seeing what part of the code actually does that.
There was a problem hiding this comment.
Oops. I amended the commit.
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
The seedfile needs to have the size of the entropy accumulator, which is 64 bytes (512 bits) since the entropy accumulator uses SHA-512 and the seed size needs to be the same as the hash output (or larger). We used to enable MBEDTLS_ENTROPY_FORCE_SHA256 in the full config, so the entropy accumulator was 256 bits (32 bytes), and therefore a 32-byte seedfile worked. But we no longer turn on this option in the full config, so the 32-byte seedfile no longer works. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
The "full" configuration excludes some deprecated or experimental features. Enable the ones that have tests, don't have extra requirements and don't turn off some other feature. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
basic-build-test-status-with-deprecated
branch
from
1de46d8 to
c877c24
Compare
|
CI run of |
mpg
approved these changes
Apr 10, 2020
ronald-cron-arm
approved these changes
Apr 10, 2020
gilles-peskine-arm
added
approved
|
The PR CI has passed and |
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs partial backports. This PR is release-critical, but the backports aren't (we can check the logs manually to verify that there are no failures).
Alternative that does change the full config: #3180
Backports: #3375 (2.16), #3376 (2.7).