Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic-build-test.sh exits successfully even if some tests fail #3178

Closed
gilles-peskine-arm opened this issue Apr 9, 2020 · 0 comments · Fixed by #3181 or #3375
Closed

basic-build-test.sh exits successfully even if some tests fail #3178

gilles-peskine-arm opened this issue Apr 9, 2020 · 0 comments · Fixed by #3181 or #3375
Labels
bug component-platform Portability layer and build scripts

Comments

@gilles-peskine-arm
Copy link
Contributor

tests/scripts/basic-build-test.sh exits successfully even if there were test failures.

I think it does make sense to run the script to completion even if there are failures. Coverage information can be useful even if some tests fail. However this should not result in a pass on the CI.

The script reports the number of failed test cases. It should exit 1 if this number is nonzero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-platform Portability layer and build scripts
Projects
None yet
Milestone
No milestone
1 participant
@gilles-peskine-arm