This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Added reset password #350
Merged
Merged
Added reset password #350
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
255a5d1
Added reset password
laurislopata d76a862
Merge branch 'main' into laurislopata/reset-password
laurislopata 425a020
Added failure listener
laurislopata 043b8e7
Made the function private
laurislopata 9576617
Deleted listener
laurislopata 2ad6ecc
Added toast
laurislopata 167cde1
Deleted tests
laurislopata 7b0f939
Fixing CI tests
laurislopata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,13 @@ class AuthenticationActivity : AppCompatActivity() { | |
signInGoogle() | ||
} | ||
|
||
/** | ||
* Listener bound to the "Reset Password" button in the Authentication activity. | ||
*/ | ||
fun resetPasswordListener(view: View) { | ||
resetPassword(username.text.toString()) | ||
} | ||
|
||
/** | ||
* Listener bound to the red return button in the Authentication activity. | ||
*/ | ||
|
@@ -249,5 +256,15 @@ class AuthenticationActivity : AppCompatActivity() { | |
private fun updateOnFail(text: String = "Authentication failed"){ | ||
Toast.makeText(baseContext, text, Toast.LENGTH_SHORT).show() | ||
} | ||
|
||
/** | ||
* Reset Password function | ||
* @param email email adress for the password reset | ||
*/ | ||
private fun resetPassword(email: String) { | ||
auth.sendPasswordResetEmail(email).addOnFailureListener { | ||
Toast.makeText(baseContext, R.string.authentication_forgotPassword, Toast.LENGTH_SHORT).show() | ||
} | ||
} | ||
Comment on lines
+260
to
+268
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe could have been into FirebaseAuth module no ? |
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, already addressed this one, since there's no way to test Toast I deleted this test :(