-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
|
||
onView(withId(R.id.username)).perform(ViewActions.typeText(email), closeSoftKeyboard()) | ||
onView(withId(R.id.forgotPassword)).perform(click()) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, already addressed this one, since there's no way to test Toast I deleted this test :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good code! Just an extra space or two, same with lines, here and there. Not very important, you can ignore those if you want, but would be good if you could change them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Below is a small comment, don't know what you think but not very important for now.
Approved! 😃
/** | ||
* Reset Password function | ||
* @param email email adress for the password reset | ||
*/ | ||
private fun resetPassword(email: String) { | ||
auth.sendPasswordResetEmail(email).addOnFailureListener { | ||
Toast.makeText(baseContext, R.string.authentication_forgotPassword, Toast.LENGTH_SHORT).show() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe could have been into FirebaseAuth module no ?
Code Climate has analyzed commit 7b0f939 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 86.3% (-0.2% change). View more on Code Climate. |
No description provided.