Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Added reset password #350

Merged
merged 8 commits into from
May 26, 2022
Merged

Added reset password #350

merged 8 commits into from
May 26, 2022

Conversation

laurislopata
Copy link
Collaborator

No description provided.


onView(withId(R.id.username)).perform(ViewActions.typeText(email), closeSoftKeyboard())
onView(withId(R.id.forgotPassword)).perform(click())

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, already addressed this one, since there's no way to test Toast I deleted this test :(

Copy link
Collaborator

@Tsathogguaa Tsathogguaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code! Just an extra space or two, same with lines, here and there. Not very important, you can ignore those if you want, but would be good if you could change them

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍
Below is a small comment, don't know what you think but not very important for now.
Approved! 😃

Comment on lines +260 to +268
/**
* Reset Password function
* @param email email adress for the password reset
*/
private fun resetPassword(email: String) {
auth.sendPasswordResetEmail(email).addOnFailureListener {
Toast.makeText(baseContext, R.string.authentication_forgotPassword, Toast.LENGTH_SHORT).show()
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could have been into FirebaseAuth module no ?

@codeclimate
Copy link

codeclimate bot commented May 26, 2022

Code Climate has analyzed commit 7b0f939 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 86.3% (-0.2% change).

View more on Code Climate.

@laurislopata laurislopata merged commit 5d12713 into main May 26, 2022
@laurislopata laurislopata deleted the laurislopata/reset-password branch May 26, 2022 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants