createProfileActivity: mock Authenticator #269
Conversation
| @@ -69,9 +86,9 @@ class CreateProfileActivityTest { | |||
|
|
|||
| val intent = Intent(ApplicationProvider.getApplicationContext(), CreateProfileActivity::class.java) | |||
| intent.putExtra("email", mockEmail) | |||
| intent.putExtra("isUnitTest", true) | |||
There was a problem hiding this comment.
Nooooo bye my friend isUnitTest, you had a great life 😂😂😂😂 !!!
There was a problem hiding this comment.
ahahahahahhahaa bye-bye and never come back please
| /** | ||
| * Getter for the current user ID | ||
| */ | ||
| fun getCurrUID(): String { | ||
| var uid = "" | ||
| if (isLoggedIn()) { | ||
| uid = FirebaseAuth.getInstance().currentUser!!.uid | ||
| } | ||
| return uid | ||
| } |
There was a problem hiding this comment.
| /** | |
| * Getter for the current user ID | |
| */ | |
| fun getCurrUID(): String { | |
| var uid = "" | |
| if (isLoggedIn()) { | |
| uid = FirebaseAuth.getInstance().currentUser!!.uid | |
| } | |
| return uid | |
| } |
See 40 lines above !!!
getCurrentUID() exactly the same 😂
There was a problem hiding this comment.
yes, but when you mock, you cant access one from the above
There was a problem hiding this comment.
I will mock others as well, and remove those from companion object. sounds good?
There was a problem hiding this comment.
Ohh okay I see, yes maybe removing the companion object may be a good idea because I find it weird otherwise to have two times the same code.
There was a problem hiding this comment.
It is... I decided to remove one by one, so it easier to check!
There was a problem hiding this comment.
I will remove these function on the next pr since there a lot of dependencies. My next pr (where these repetetive functions are removed) is almost done!
|
Code Climate has analyzed commit 317c9fc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 28.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.2% (0.1% change). View more on Code Climate. |
This PR mocks authenticator in the createProfileActivity.