Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Kamila/mock authenticator #272

Merged
merged 18 commits into from
May 9, 2022
Merged

Kamila/mock authenticator #272

merged 18 commits into from
May 9, 2022

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented May 9, 2022

This PR:

  • mock authenticator in WelcomeActivity, GameActivity
  • remove companion object from FirebaseAuthenticator

@kamilababayeva kamilababayeva self-assigned this May 9, 2022
@kamilababayeva kamilababayeva linked an issue May 9, 2022 that may be closed by this pull request
@MaximeZmt MaximeZmt self-requested a review May 9, 2022 11:20
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 !
Some small modifications that need to be done :) !

@codeclimate
Copy link

codeclimate bot commented May 9, 2022

Code Climate has analyzed commit 9c38c6f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.2% (80% is the threshold).

This pull request will bring the total coverage in the repository to 82.7% (0.5% change).

View more on Code Climate.

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@jiabaow jiabaow self-requested a review May 9, 2022 12:13
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilababayeva kamilababayeva merged commit d77b3b3 into main May 9, 2022
@kamilababayeva kamilababayeva deleted the kamila/mock_game_activity branch May 9, 2022 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock Authenticator
3 participants