-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run web platform tests in browsers #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattiasBuelens
added
enhancement
domain: compliance
Issues related to compliance with the streams standard
labels
Sep 28, 2021
The "pull_request" workflow acts more as a "sanity check" that the PR branch is sufficiently up-to-date with the base branch. We leave the real heavy lifting over to the "push" workflow.
MattiasBuelens
force-pushed
the
run-wpt-in-browser
branch
from
September 28, 2021 22:50
394e514
to
3f95e79
Compare
MattiasBuelens
force-pushed
the
run-wpt-in-browser
branch
from
September 28, 2021 22:52
3f95e79
to
aa8bb65
Compare
This is awkward...
Closed
Thanks @MattiasBuelens for outlining what issues you had with getting
cc @gsnedders @jgraham @past FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only ran the web platform tests (WPT) against Node using wpt-runner. This works fine, but it's not perfect:
This PR adds the test infrastructure to also run WPT against actual browsers. I use Playwright to spin up a headless Chromium or Firefox browser, start a local web server, run all the tests and collect the results back inside Node. I tried to keep it as close as possible to how we run WPT on Node, to make it easier to understand and maintain.
Alternatives considered:
wpt run
as suggested in Running WPT #78. This is a Python tool used by the WPT project itself to run the tests. Although I eventually managed to get it to run, I decided not to go this route:wpt update-expectations
, but I found it to not be granular enough.