Loosen brand checks on ReadableStream methods #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #96, #98 and #99, we made
pipeTo()
,pipeThrough()
,tee()
and[Symbol.asyncIterator]()
use only the public API rather than relying on internal abstract operations.This PR brings it all together by loosening the brand checks on these methods. You'll now be able to call
readable.pipeTo(writable)
with anywritable
that "looks like" aWritableStream
, i.e. anything that has a sufficiently compliantgetWriter()
method. This includes nativeWritableStream
s, or evenWritableStream
s constructed by a different polyfill. 😁In theory, you could also call these on anything that "looks like" a
ReadableStream
, although it's currently still a bit awkward: