-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lld when building with mzcompose on macOS #30797
Conversation
db231c3
to
ddf6cf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a ton of sense. Just one comment about limiting the -B
argument to just lld.
@def- I'm inclined to say that if we go this route, we shouldn't have the homebrew-toolchains repo try to install lld into this sysroot. In theory the homebrew-toolchains are meant to be usable by folks outside Materialize and those folks might not want to be forced to install lld. And using lld downstream, as demonstrated here, looks pretty clean!
Incremental compile time for bin/mzcompose improves from 6min28s to 13s on my system by using lld.
Yes, absolutely. I'm not able to get that PR working properly though, and probably less importance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm!
Before this PR:
@teskje Can you try if this works for you?
Independently of this, we should also bump the crosstools-ng and the software it pulls it to get parity with ci-builder: MaterializeInc/homebrew-crosstools#10
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.