Update toolchains #10
Conversation
def-
force-pushed
the
main
branch
2 times, most recently
from
eaa208c to
f1376c1
Compare
def-
force-pushed
the
main
branch
3 times, most recently
from
dfb34f4 to
22d715f
Compare
There was a problem hiding this comment.
Unless there's something in particular we need from newer versions of glibc/Linux, I'd prefer to keep those at their existing versions. The versions of those were intentionally chosen to be the oldest versions of glibc/Linux supported for each architecture's toolchain, to maximize the compatibility of the resulting binary. (A binary that's linked against a certain version of glibc/Linux can't run on a system that uses an older version of glibc/Linux.)
Upgrading gcc, binutils, et al. seems fine although fair warning that newer versions of gcc/binutils do not always improve compilation speed.
Anyway, if this really does bring down link times as much as you say, this is really exciting!
lib/toolchain.rb
Outdated
| brew_prefix = Pathname.new(ENV["HOMEBREW_PREFIX"] || "/usr/local/homebrew") | ||
| ln_s brew_prefix/"bin/lld", "mnt/install/bin/ld.lld" |
There was a problem hiding this comment.
This looks sketchy. I think the standard pattern looks more like this: https://stackoverflow.com/a/73408649
There was a problem hiding this comment.
We do a similar thing to get lld support there: https://github.com/MaterializeInc/materialize/blob/92acf2387bb0ff7331d7d452857d399801fb314a/ci/builder/Dockerfile#L213-L214
There was a problem hiding this comment.
I don't think the stackoverflow thread's approach works to get lld working. I did find another approach though, so this PR might not be necessary to get the lld speedup: MaterializeInc/materialize#30797
I still think we should bring the crosstools-ng in macOS to parity with ci-builder.
| @@ -0,0 +1,140 @@ | |||
| From: Francois-Xavier Coudert <[email protected]> | |||
There was a problem hiding this comment.
Why not use gcc 13.3? It seems like this patch is included in 13.3.
There was a problem hiding this comment.
I wanted to make sure we have the same versions as in ci-builder (plus these fixes for the build)
|
In theory, the bottles will be automatically added by https://github.com/MaterializeInc/homebrew-crosstools/blob/main/.github/workflows/publish.yml after merge. Who knows if that's still working after all these years, though. |
|
I did not want to upgrade toolchains, but it's my understanding that in homebrew you can't pick an older version as a dependency, so I had to upgrade crosstools-ng to get a new build. I picked the same versions we use in ci-builder. We do a similar thing to get lld support there: https://github.com/MaterializeInc/materialize/blob/92acf2387bb0ff7331d7d452857d399801fb314a/ci/builder/Dockerfile#L213-L214 |
def-
force-pushed
the
main
branch
3 times, most recently
from
05bd2f0 to
27fc073
Compare
|
Something is still wrong here. I can build this successfully with I also don't understand why |
def-
force-pushed
the
main
branch
4 times, most recently
from
36c27c2 to
8a28f56
Compare
Incremental compile time for bin/mzcompose improves from 6min28s to 13s on my system by using lld.
I'm also not sure how to upload the artifacts for this to homebrew. @benesch I guess you have access to do so.
Moved this PR from #9 because it refers to the main branch via tap directory.