Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlsmith: Update version, ignore *in types #23131

Merged
merged 1 commit into from
Nov 11, 2023
Merged

sqlsmith: Update version, ignore *in types #23131

merged 1 commit into from
Nov 11, 2023

Conversation

def-
Copy link
Contributor

@def- def- commented Nov 11, 2023

Introduced in #23130, all unsupported, see failure in https://buildkite.com/materialize/nightlies/builds/5145

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@def- def- force-pushed the pr-sqlsmith-in-types branch from 9bc552b to 78c6830 Compare November 11, 2023 22:05
@def- def- marked this pull request as ready for review November 11, 2023 23:25
@def- def- enabled auto-merge November 11, 2023 23:25
@def- def- requested a review from benesch November 11, 2023 23:25
benesch
benesch approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Sorry for the breakage.

@def- def- merged commit 3f9e223 into MaterializeInc:main Nov 11, 2023
@def- def- deleted the pr-sqlsmith-in-types branch November 12, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesch benesch benesch approved these changes

@philip-stoev philip-stoev Awaiting requested review from philip-stoev

@nrainer-materialize nrainer-materialize Awaiting requested review from nrainer-materialize

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @benesch