test/lang: add ruby language tests #23130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type mapper in Ruby's pg gem runs an introspection query that joins `pg_type` with `pg_proc` on `pg_type.typinput`. It only cares about the `pg_proc.procname` column, so add stub implementations for all the typinput routines, just like we already do for the typreceive routines.
maddyblue
approved these changes
Nov 11, 2023
You bet! It started small and then one thing led to another .. and another .. and another. |
To ensure that type mapping with the pg gem works as desired.
def-
added a commit
to MaterializeInc/sqlsmith
that referenced
this pull request
Nov 11, 2023
Introduced in MaterializeInc/materialize#23130, all unsupported, see failure in https://buildkite.com/materialize/nightlies/builds/5145
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 11, 2023
Introduced in MaterializeInc#23130, all unsupported, see failure in https://buildkite.com/materialize/nightlies/builds/5145
5 tasks
def-
added a commit
to def-/materialize
that referenced
this pull request
Nov 11, 2023
Introduced in MaterializeInc#23130, all unsupported, see failure in https://buildkite.com/materialize/nightlies/builds/5145
def-
added a commit
to MaterializeInc/sqlsmith
that referenced
this pull request
Nov 11, 2023
Introduced in MaterializeInc/materialize#23130, all unsupported, see failure in https://buildkite.com/materialize/nightlies/builds/5145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that type mapping with the pg gem works as desired.
Motivation
This PR fixes a previously unreported bug.
Type mapping with the Ruby
pggem (see enclosed test) did not work.Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.