Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find vs installation of ninja #100

Closed
wants to merge 1 commit into from
Closed

find vs installation of ninja #100

wants to merge 1 commit into from

Conversation

aozgaa
Copy link

@aozgaa aozgaa commented May 29, 2024 •
edited
Loading

Fixes #99

Uses the vs-installation of ninja with Ninja* build generators (eg: Ninja and Ninja Multi-Config).

Test Plan

  • build example projects on my machine -- works with non-core powershell and minor edits to examples/build.ps1, but those are outside the scope of this change
  • It doesn't seem there are any Pester tests contrary to the readme.

@aozgaa aozgaa requested a review from MarkSchofield as a code owner May 29, 2024 20:47
@MarkSchofield MarkSchofield mentioned this pull request Jun 1, 2024
Closed
@MarkSchofield
Copy link
Owner

I've proposed an alternate fix in #120.

@MarkSchofield
Copy link
Owner

#120 should fix this. Let me know if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkSchofield MarkSchofield Awaiting requested review from MarkSchofield MarkSchofield is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toolchains don't find VS Ninja install
2 participants
@aozgaa @MarkSchofield