Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not emit unused warning for variables named unused* #87

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

dalcinl
Copy link
Contributor

@dalcinl dalcinl commented Nov 26, 2023

Cython has its own warning for unused variables, which is enabled with -Wextra. However, the warning does not trigger if the variable is named _ or if the variable name starts with unused.

@MarcoGorelli
Copy link
Owner

thanks @dalcinl ! fancy adding a little test case?

Cython has its own warning for unused variables, which is enabled with
`-Wextra`. However, the warning does not trigger if the variable is named
`_` or if the variable name starts with `unused`.
Copy link
Owner

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dalcinl , lovely!

@MarcoGorelli MarcoGorelli merged commit 7b645c8 into MarcoGorelli:main Nov 26, 2023
10 checks passed
@dalcinl dalcinl deleted the patch-1 branch April 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants