Merge pull request #87 from dalcinl/patch-1

do not emit unused warning for variables named `unused*`
MarcoGorelli · Nov 26, 2023 · 7b645c8 · 7b645c8
2 parents c0a33b2 + e7ed425
commit 7b645c8
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/cython_lint/cython_lint.py b/cython_lint/cython_lint.py
@@ -256,6 +256,7 @@ def visit_funcdef(
             and _def[0] != func_name
             and _def[0] not in [i[0] for i in args]
             and not _def[0].startswith('_')
+            and not _def[0].startswith('unused')
             and _def[0] not in global_names
         ):
 

diff --git a/tests/main_test.py b/tests/main_test.py
@@ -13,6 +13,43 @@
 INCLUDE_FILE_1 = os.path.join('tests', 'data', 'bar.pxi')
 
 
+@pytest.mark.parametrize(
+    'src',
+    [
+        (
+            'cdef bint foo():\n'
+            '    cdef int _\n'
+            '    cdef int _a\n'
+            '    cdef int unused\n'
+            '    cdef int unused_a\n'
+        ),
+        (
+            'cdef bint foo():\n'
+            '    cdef int _ = 1\n'
+            '    cdef int _a = 1\n'
+            '    cdef int unused = 1\n'
+            '    cdef int unused_a = 1\n'
+        ),
+        (
+            'cdef bint foo():\n'
+            '    cdef int _\n'
+            '    cdef int _a\n'
+            '    cdef int unused\n'
+            '    cdef int unused_a\n'
+            '    _ = 1\n'
+            '    _a = 1\n'
+            '    unused = 1\n'
+            '    unused_a = 1\n'
+        ),
+    ],
+)
+def test_named_unused(capsys: Any, src: str) -> None:
+    ret = _main(src, 't.py', ext='.pyx', no_pycodestyle=True)
+    out, _ = capsys.readouterr()
+    assert out == ''
+    assert ret == 0
+
+
 @pytest.mark.parametrize(
     'src, expected',
     [