Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix union of frozendict for python implementation #89

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Fix union of frozendict for python implementation #89

merged 2 commits into from
Nov 18, 2023

Conversation

apmorton
Copy link
Contributor

Fixes #84

Marco-Sulla
Marco-Sulla previously requested changes Nov 18, 2023
View reviewed changes
Copy link
Owner

@Marco-Sulla Marco-Sulla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and will fix things for Python 3.9+, but this will not fix the wrong frozendict_or function.

@Marco-Sulla
Copy link
Owner

Please ignore my previous comment, I was a little tired and I didn't review your change carefully.

@Marco-Sulla Marco-Sulla reopened this Nov 18, 2023
@Marco-Sulla Marco-Sulla dismissed their stale review November 18, 2023 19:35

I am a cow.

@Marco-Sulla Marco-Sulla merged commit db44acb into Marco-Sulla:master Nov 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marco-Sulla Marco-Sulla Marco-Sulla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Union of frozendict and frozendict results in dict
2 participants
@apmorton @Marco-Sulla