Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Union of frozendict and frozendict results in dict #84

Closed
rindPHI opened this issue Oct 2, 2023 · 1 comment · Fixed by #89
Closed

[BUG] Union of frozendict and frozendict results in dict #84

rindPHI opened this issue Oct 2, 2023 · 1 comment · Fixed by #89
Labels
Effort: Low easy task Needs: Test Hey, it compiles! Ship it! Priority: High A blocking bug or an important feature Type: Bug Something isn't working

Comments

@rindPHI
Copy link

rindPHI commented Oct 2, 2023

The union of a frozendict with | should again result in a frozendict, but does actually result in a mutable dict.

OS version: macOS 13.5.2
frozendict version: 2.3.8
Python3 version (python3 -V -V): Python 3.11.5 (main, Aug 24 2023, 15:18:16) [Clang 14.0.3 (clang-1403.0.22.14.1)]

Steps to reproduce:

In [1]: from frozendict import frozendict
In [2]: a = frozendict({1: 2})
In [3]: type(a | a)
Out[3]: dict

Expected result:
frozendict

Actual result:
dict

@Marco-Sulla
Copy link
Owner

Confirmed. The problem is in the pure py implementation, probably in the left operand

@Marco-Sulla Marco-Sulla self-assigned this Oct 3, 2023
@Marco-Sulla Marco-Sulla added Type: Bug Something isn't working Priority: High A blocking bug or an important feature Effort: Low easy task Needs: Test Hey, it compiles! Ship it! labels Oct 3, 2023
@Marco-Sulla Marco-Sulla removed their assignment Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Low easy task Needs: Test Hey, it compiles! Ship it! Priority: High A blocking bug or an important feature Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants