Replace 'values' key with 'default_value' when updating value for field

[eclarizio]

This should fix
https://bugzilla.redhat.com/show_bug.cgi?id=1706693
https://bugzilla.redhat.com/show_bug.cgi?id=1710312
https://bugzilla.redhat.com/show_bug.cgi?id=1704695
https://bugzilla.redhat.com/show_bug.cgi?id=1706600
https://bugzilla.redhat.com/show_bug.cgi?id=1715396
https://bugzilla.redhat.com/show_bug.cgi?id=1713419

Basically, we made this change but neglected to change the ui-components side on refresh callback, so it was still using the old values but that key no longer was being returned.

@himdel Please Review

@miq-bot add_label bug
@miq-bot assign @himdel

[miq-bot]

Checked commit eclarizio@7dcb1f7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

[d-m-u]

looks good to me

[tinaafitz]

@Fryguy Can you merge this PR? Brno is on holiday today and this change is needed for several high severity issues.

[simaishi]

@eclarizio I assume this is hammer/yes?

[eclarizio]

@simaishi Yeah, you're correct.

@miq-bot add_label hammer/yes

[tinaafitz]

Hi @simaishi We tested the code change on the following tickets and are satisfied it addresses the reported issues.

https://bugzilla.redhat.com/show_bug.cgi?id=1706693
https://bugzilla.redhat.com/show_bug.cgi?id=1710312
https://bugzilla.redhat.com/show_bug.cgi?id=1704695
https://bugzilla.redhat.com/show_bug.cgi?id=1696474
https://bugzilla.redhat.com/show_bug.cgi?id=1706600

[simaishi]

Hammer backport details:

$ git log -1
commit 65ad1c7e7933096547863e5c42d0d6364bfa8864
Author: Jason Frey <[email protected]>
Date:   Wed May 8 12:30:44 2019 -0400

    Merge pull request #384 from eclarizio/fix_for_dynamic_non_sorted_items
    
    Replace 'values' key with 'default_value' when updating value for field
    
    (cherry picked from commit 578c154c3e3846f251e9c065ac11f38a5d187c7b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1710578
    https://bugzilla.redhat.com/show_bug.cgi?id=1710606
    https://bugzilla.redhat.com/show_bug.cgi?id=1710608
    https://bugzilla.redhat.com/show_bug.cgi?id=1710610

[simaishi]

@himdel Can you please release a new version of ui-components for this change for hammer branch?

[simaishi]

FYI, Travis is red on hammer for yet another 'node' incompatible error:
https://travis-ci.org/ManageIQ/ui-components/builds/533011740

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=8.15.0".
error Found incompatible module

[himdel]

Released in 1.1.26, and I think backporting #361 is probably the best way to fix travis after all..