Fix for incorrect key sent back for dynamic non sorted items #18650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
fix_for_dynamic_fields_not_being_updated
branch
5 times, most recently
from
c1bba2c to
03e58f4
Compare
d-m-u
approved these changes
Apr 11, 2019
d-m-u
reviewed
Apr 11, 2019
eclarizio
force-pushed
the
fix_for_dynamic_fields_not_being_updated
branch
from
03e58f4 to
b542dad
Compare
|
Checked commit eclarizio@b542dad with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@eclarizio if #18652 is hammer specific, then it appears we can remove the hammer/yes label on this PR. Correct? |
|
@miq-bot remove_label hammer/yes |
|
Backported to Hammer via #18652 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the below linked BZ, there was an issue when verifying the original fix which can be found here on the ui-components repo.
Basically, for dynamic dialogs, we were returning the dynamically computed result in a key called
"values". But, this does not really make sense for text boxes, check boxes, or date/times because those fields can only have one value, not a list of values. So, this PR changes that so that we can still continue to useng-model=vm.dialogField.default_valuewhich makes the most sense while also passing through the correctly computeddefault_valuefrom the automate side for those various types of dialog fields.This will also need this other ui-components PR to revert the
ng-modelchanges made in 381.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696474
/cc @tinaafitz @d-m-u @himdel @gmcculloug