Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected condition testing emptiness of dialog field #377

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Corrected condition testing emptiness of dialog field #377

merged 1 commit into from
Mar 27, 2019

Conversation

romanblanco
Copy link
Member

This change is correcting a test for emptiness of a service dialog field.

The problem now is the button to submit the form is disabled, because the field with validation is treated as not empty (fieldValue is of value null) and therefore with invalid value.

Screencast from 2019-03-27 12-47-30

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1692736

@miq-bot
Copy link
Member

miq-bot commented Mar 27, 2019

Checked commit romanblanco@4cade91 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@h-kataria
Copy link
Contributor

looks good.

@martinpovolny martinpovolny merged commit ba48151 into ManageIQ:master Mar 27, 2019
@martinpovolny martinpovolny self-assigned this Mar 27, 2019
@martinpovolny martinpovolny added this to the Sprint 108 Ending Apr 1, 2019 milestone Mar 27, 2019
@romanblanco romanblanco deleted the bz1692736 branch March 28, 2019 06:47
@romanblanco
Copy link
Member Author

@miq-bot add_label hammer/yes

This was referenced Apr 9, 2019
Merged
Merged
simaishi pushed a commit that referenced this pull request Apr 22, 2019
@martinpovolny @simaishi
Merge pull request #377 from romanblanco/bz1692736
c541376 
Corrected condition testing emptiness of dialog field

(cherry picked from commit ba48151)

https://bugzilla.redhat.com/show_bug.cgi?id=1702063
@simaishi
Copy link

Hammer backport details:

$ git log -1
commit c5413764a9fed32dbe8bee47bff90fad378b6be1
Author: Martin Povolny <[email protected]>
Date:   Wed Mar 27 17:18:33 2019 +0100

    Merge pull request #377 from romanblanco/bz1692736
    
    Corrected condition testing emptiness of dialog field
    
    (cherry picked from commit ba48151672e61c47d5727e4ada16272283b9bf82)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1702063

This was referenced Apr 23, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinpovolny martinpovolny

Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romanblanco @miq-bot @h-kataria @simaishi @martinpovolny