Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HAMMER] Update ui-components to 1.1.23 for hammer #1540

Merged
merged 1 commit into from
Apr 23, 2019
Merged

[HAMMER] Update ui-components to 1.1.23 for hammer #1540

merged 1 commit into from
Apr 23, 2019

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 23, 2019

@miq-bot miq-bot changed the title Update ui-components to 1.1.23 for hammer [HAMMER] Update ui-components to 1.1.23 for hammer Apr 23, 2019
@miq-bot
Copy link
Member

miq-bot commented Apr 23, 2019

Checked commit https://github.com/himdel/manageiq-ui-service/commit/ca2f12ca03efbfbe9a5b34da25d88f551d3380c5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@simaishi simaishi requested a review from AllenBW April 23, 2019 13:55
AllenBW
AllenBW approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@AllenBW AllenBW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okie dokie to me, thanks for keepin up with these @himdel ! 🤗

@simaishi simaishi merged commit 1194723 into ManageIQ:hammer Apr 23, 2019
@simaishi simaishi added this to the Sprint 110 Ending Apr 29, 2019 milestone Apr 23, 2019
@himdel himdel deleted the uic-1.1.23 branch June 17, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenBW AllenBW AllenBW approved these changes

Assignees

@simaishi simaishi

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himdel @miq-bot @AllenBW @simaishi