Allow setting default value for date/time picker in Dialog Editor modal #373

romanblanco · 2019-03-14T14:20:46Z

Adding an option to set default value for date/time picker in Dialog Editor modal:

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1686077

kedark3 · 2019-03-14T19:44:46Z

Just wondering, I had originally reported this BZ, and like to understand, would this allow default date to be dynamically selected as today's date, and every time I open a catalog containing this datetimepicker, I would like it to default to whatever is the date that day, is it possible?

Loicavenel · 2019-03-15T07:43:11Z

@kedark3, what is your use case here..

kedark3 · 2019-03-15T14:27:24Z

@Loicavenel in CFME QE team, we are deploying a catalog item, where user can tell us name of provider, template to clone, VM name, service name, and retirement date. In case user does not choose retirement date, it should be set by default to whatever is current date+X hours. I was wondering if we can set that current date+X hours while we create the dialog. Now, in current implementation of our catalog, the default date we see while ordering the catalog is current date and time.

This is an attempt to make sure the VM is removed/retired automatically after certain time if user does not extend it.

Does it make sense? I am not sure if we can design that in datetimepicker or in automate.

Loicavenel · 2019-03-16T12:32:04Z

@kedark3 this is more for Automate, you want to introduce a rules that say, if no Retirement selected, automatically take current order date + X

kedark3 · 2019-03-19T00:24:24Z

@Loicavenel thanks for clarifying. Just wanted to make sure if this was not something that we should be doing in this PR/BZ.

himdel · 2019-03-19T13:09:52Z

@romanblanco Are you sure about the BZ in description?

The BZ linked from here says "I can't view bug 1598729", and is marked as closed and a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1676724.

The bug mentioned in that BZs subject is a RHEL bug.

The branch name seems most correct, https://bugzilla.redhat.com/show_bug.cgi?id=1686077 is indeed related to the code here :).

Can you fix the description & commit message please, if that's the right bug? :) (Both description and the commit message have the wrong link.)

himdel · 2019-03-19T13:22:39Z

Verified in UI

both the date and datetime pickers can now have a default value,
the templates are identical except for an extra timepicker for the datetime case.

One nitpick, it's currently impossible to remove the default value using mouse, you have to select the date and press delete. Could we add an x button to clear the default value?

EDIT: and completely impossible for date&time

himdel · 2019-03-19T13:26:03Z

Uh, one more bug...

have a datetime item,
set a default value,
remove the date in the default value,
try to remove the time (the fields will be red),
switch tabs to Field Information and back to Options

romanblanco · 2019-03-29T10:16:01Z

@romanblanco Are you sure about the BZ in description?

The BZ linked from here says "I can't view bug 1598729", and is marked as closed and a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1676724.

The bug mentioned in that BZs subject is a RHEL bug.

The branch name seems most correct, https://bugzilla.redhat.com/show_bug.cgi?id=1686077 is indeed related to the code here :).

Can you fix the description & commit message please, if that's the right bug? :) (Both description and the commit message have the wrong link.)

The link was incorrect. It is correct now. Thanks!

romanblanco · 2019-04-03T09:17:28Z

Uh, one more bug...

have a datetime item,
set a default value,
remove the date in the default value,
try to remove the time (the fields will be red),
switch tabs to Field Information and back to Options

I'm trying to fix this by using patternfly angular component introduced in patternfly/angular-patternfly#344, used in https://github.com/ManageIQ/manageiq/pull/12165/files#diff-f5af660797161cfea689526173ffec72R92

I'm working on this in WIP branches:
master...romanblanco:bz1686077-v1
ManageIQ/manageiq-ui-classic@master...romanblanco:bz1686077-v1

mzazrivec · 2019-04-05T08:54:42Z

src/dialog-editor/components/modal/modalComponent.ts

+   * @function clearDefaultValue
+   */
+  public clearDefaultValue() {
+    console.log(this.modalData.default_value);


Why is the console.log here?

romanblanco · 2019-09-03T12:33:21Z

TODO:

'Clear' button works, but error appears:

Error: "[$rootScope:inprog] $digest already in progress
https://errors.angularjs.org/1.6.10/$rootScope/inprog?p0=%24digest"

Loading the default_value into the Dialog Editor (Saving works correctly, but loading replaces default_value with today's date)

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1686077

himdel · 2019-09-10T11:23:36Z

src/dialog-editor/components/field/field.html

    <!-- date time control -->
    <div ng-switch-when="DialogFieldDateTimeControl">
      <div class="col-sm-6 dateTimePadding">
-        <input ng-model="vm.fieldData.default_value"
-               pf-datepicker options="vm.fieldData.dateOptions"


dateOptions is intentionally removed? (I'm not seeing it defined anywhere, so sounds about right, just checking :), line 33 does have datepicker-options, line 53 doesn't)

dateOptions is intentionally removed?

yes.

line 33 does have datepicker-options

Thanks! Removing 👍

himdel · 2019-09-11T13:56:22Z

One last thing... diff between date-control and date-time-control:

--- src/dialog-editor/components/modal-field-template/date-control.html	2019-09-11 13:08:07.824862101 +0000
+++ src/dialog-editor/components/modal-field-template/date-time-control.html	2019-09-11 13:08:07.824862101 +0000
@@ -1,5 +1,12 @@
 <div ng-if="vm.modalTabIsSet('options') && !vm.modalData.dynamic">
   <form class="form-horizontal">
+    <div pf-form-group pf-label="{{'Required'|translate}}">
+      <input bs-switch
+             ng-model="vm.modalData.required"
+             type="checkbox"
+             switch-on-text="{{'Yes'|translate}}"
+             switch-off-text="{{'No'|translate}}">
+    </div>
     <div pf-form-group pf-label="{{'Default value'|translate}}">
       <div class="dateTimePadding">
         <p class="input-group">
@@ -8,16 +15,20 @@
                  class="form-control"
                  ng-model="vm.modalData.default_value"
                  is-open="open"
-                 close-text="{{'Close'|translate}}"/>
+                 min-date="vm.minDate"
+                 close-text="{{'Close'|translate}}"
+                 id="{{ vm.dialogField.name }}"/>
           <span class="input-group-btn">
             <button type="button"
                     class="btn btn-default"
                     ng-click="open = !open">
-              <i class="fa fa-calendar"></i>
-            </button>
+              <i class="fa fa-calendar"></i></button>
           </span>
         </p>
       </div>
+      <div >
+        <uib-timepicker ng-model="vm.modalData.default_value"></uib-timepicker>
+      </div>
     </div>
     <div pf-form-group pf-label="{{'Read only'|translate}}">
       <input bs-switch
@@ -75,6 +86,14 @@
       </dialog-editor-modal-field-template>
     </div>
 
+    <div pf-form-group pf-label="{{'Required'|translate}}">
+      <input bs-switch
+             ng-model="vm.modalData.required"
+             type="checkbox"
+             switch-on-text="{{'Yes'|translate}}"
+             switch-off-text="{{'No'|translate}}">
+    </div>
+
     <dialog-editor-tree-selector ng-if="vm.treeOptions.show"
                                  tree-options="vm.treeOptions">
     </dialog-editor-tree-selector>

Specifically, it seems like date-time-control now has 2 copies of the Required switch, while date-control has none. (Comes from #380)

I assume the only difference between the two should be the extra uib-timepicker?

romanblanco · 2019-09-11T14:03:12Z

required option is missing in the new template, as it was copied before 1e89fe6 was merged. I'll update the template so it has an option to set required too.

Thanks @himdel

miq-bot · 2019-09-11T14:47:52Z

Checked commits romanblanco/ui-components@5d43974~...e6f5aae with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

himdel · 2019-09-12T14:10:28Z

LGTM, working :) thanks :)

Allow setting default value for date/time picker in Dialog Editor modal (cherry picked from commit 8811c76) https://bugzilla.redhat.com/show_bug.cgi?id=1686077 https://bugzilla.redhat.com/show_bug.cgi?id=1706848

simaishi · 2020-08-20T13:04:44Z

Ivanchuk backport details:

$ git log -1
commit 8660c6fb47a725f3fefb676bdfbd45fa2ab83f80
Author: Martin Hradil <[email protected]>
Date:   Thu Sep 12 16:10:20 2019 +0200

    Merge pull request #373 from romanblanco/bz1686077

    Allow setting default value for date/time picker in Dialog Editor modal

    (cherry picked from commit 8811c766d812d37d91cf89f5b455999d81bf20c6)

    https://bugzilla.redhat.com/show_bug.cgi?id=1686077
    https://bugzilla.redhat.com/show_bug.cgi?id=1706848

himdel closed this Mar 19, 2019

himdel reopened this Mar 19, 2019

romanblanco force-pushed the bz1686077 branch 2 times, most recently from 8d3ab25 to c2613ff Compare March 29, 2019 12:45

romanblanco mentioned this pull request Apr 1, 2019

Showing default value for date/time picker in service dialog preview ManageIQ/manageiq-ui-classic#5400

Merged

romanblanco force-pushed the bz1686077 branch from c2613ff to e50b6ae Compare April 1, 2019 13:07

mzazrivec reviewed Apr 5, 2019

View reviewed changes

romanblanco changed the title ~~Allow setting default value for date/time picker in Dialog Editor modal~~ [WIP] Allow setting default value for date/time picker in Dialog Editor modal Apr 5, 2019

miq-bot added wip unmergeable labels Apr 5, 2019

himdel added the dialog editor label May 10, 2019

romanblanco force-pushed the bz1686077 branch from e50b6ae to 86e500b Compare June 3, 2019 13:23

miq-bot removed the unmergeable label Jun 5, 2019

romanblanco force-pushed the bz1686077 branch 2 times, most recently from ab3c212 to 5c4b290 Compare September 3, 2019 12:26

romanblanco force-pushed the bz1686077 branch from 5c4b290 to 1eafad0 Compare September 3, 2019 13:46

Allow setting default value for date/time picker in Dialog Editor modal

5d43974

fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1686077

romanblanco force-pushed the bz1686077 branch from 1eafad0 to cf39349 Compare September 9, 2019 12:01

romanblanco changed the title ~~[WIP] Allow setting default value for date/time picker in Dialog Editor modal~~ Allow setting default value for date/time picker in Dialog Editor modal Sep 9, 2019

romanblanco force-pushed the bz1686077 branch from cf39349 to 7b7f85a Compare September 9, 2019 12:02

Add a button to clear default value

4750ab0

miq-bot removed the wip label Sep 9, 2019

himdel reviewed Sep 10, 2019

View reviewed changes

romanblanco force-pushed the bz1686077 branch from 7b7f85a to e324336 Compare September 10, 2019 13:24

Replaced pf-datepicker component for uib-datepicker

e324336

Added missing option to set field as required

e6f5aae

himdel self-assigned this Sep 12, 2019

himdel merged commit 8811c76 into ManageIQ:master Sep 12, 2019

himdel added this to the Sprint 120 Ending Sep 16, 2019 milestone Sep 12, 2019

himdel added the bug label Sep 12, 2019

romanblanco deleted the bz1686077 branch September 13, 2019 10:29

This was referenced Oct 23, 2019

Update ui-components to 1.3.2 ManageIQ/manageiq-ui-classic#6331

Merged

Update ui-components to 1.3.2 ManageIQ/manageiq-ui-service#1596

Merged

mzazrivec added the ivanchuk/yes label Jun 11, 2020

mzazrivec mentioned this pull request Jun 11, 2020

Allow to select whole hour in dialog sample screen ManageIQ/manageiq-ui-classic#7121

Merged

simaishi added ivanchuk/backported and removed ivanchuk/yes labels Aug 20, 2020

This was referenced Sep 7, 2020

[IVANCHUK] Update ui-components to 1.2.22 ManageIQ/manageiq-ui-classic#7294

Merged

[IVANCHUK] Update ui-components to 1.2.22 ManageIQ/manageiq-ui-service#1669

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow setting default value for date/time picker in Dialog Editor modal #373

Allow setting default value for date/time picker in Dialog Editor modal #373

romanblanco commented Mar 14, 2019 •

edited

Loading

kedark3 commented Mar 14, 2019

Loicavenel commented Mar 15, 2019

kedark3 commented Mar 15, 2019

Loicavenel commented Mar 16, 2019

kedark3 commented Mar 19, 2019

himdel commented Mar 19, 2019 •

edited

Loading

himdel commented Mar 19, 2019 •

edited

Loading

himdel commented Mar 19, 2019

romanblanco commented Mar 29, 2019

romanblanco commented Apr 3, 2019 •

edited

Loading

mzazrivec Apr 5, 2019

romanblanco commented Sep 3, 2019 •

edited

Loading

himdel Sep 10, 2019

romanblanco Sep 10, 2019

himdel commented Sep 11, 2019 •

edited

Loading

romanblanco commented Sep 11, 2019

miq-bot commented Sep 11, 2019

himdel commented Sep 12, 2019

simaishi commented Aug 20, 2020

Allow setting default value for date/time picker in Dialog Editor modal #373

Allow setting default value for date/time picker in Dialog Editor modal #373

Conversation

romanblanco commented Mar 14, 2019 • edited Loading

kedark3 commented Mar 14, 2019

Loicavenel commented Mar 15, 2019

kedark3 commented Mar 15, 2019

Loicavenel commented Mar 16, 2019

kedark3 commented Mar 19, 2019

himdel commented Mar 19, 2019 • edited Loading

himdel commented Mar 19, 2019 • edited Loading

himdel commented Mar 19, 2019

romanblanco commented Mar 29, 2019

romanblanco commented Apr 3, 2019 • edited Loading

mzazrivec Apr 5, 2019

Choose a reason for hiding this comment

romanblanco commented Sep 3, 2019 • edited Loading

himdel Sep 10, 2019

Choose a reason for hiding this comment

romanblanco Sep 10, 2019

Choose a reason for hiding this comment

himdel commented Sep 11, 2019 • edited Loading

romanblanco commented Sep 11, 2019

miq-bot commented Sep 11, 2019

himdel commented Sep 12, 2019

simaishi commented Aug 20, 2020

romanblanco commented Mar 14, 2019 •

edited

Loading

himdel commented Mar 19, 2019 •

edited

Loading

himdel commented Mar 19, 2019 •

edited

Loading

romanblanco commented Apr 3, 2019 •

edited

Loading

romanblanco commented Sep 3, 2019 •

edited

Loading

himdel commented Sep 11, 2019 •

edited

Loading