Allow to select whole hour in dialog sample screen

[mzazrivec]

When creating a service dialog with timepicker, it is possible to select a default date / time for the input. Though when we render the dialog sample screen, we only allow every fifth minute to be selected and rendered.

This change allows to select and render every minute in an hour in the datepicker element.

https://bugzilla.redhat.com/show_bug.cgi?id=1706848

For the above bz to be properly addressed in ivanchuk, we need the following PR ManageIQ/ui-components#373 to be cherry-picked into ivanchuk.

[himdel]

I'm 👍 with this, but given the ...possible level of misunderstanding in the BZ, should we just make sure all these are read only?

dialog-sample is a quick preview of the dialog that the user can't really interact with anyway.
Given what they're asking, maybe we should make it clearer that this is just a sample, not something to interact with.

[h-kataria]

I'm +1 with this, but given the ...possible level of misunderstanding in the BZ, should we just make sure all these are read only?

dialog-sample is a quick preview of the dialog that the user can't really interact with anyway.
Given what they're asking, maybe we should make it clearer that this is just a sample, not something to interact with.

i was just about to comment that this PR only seems to be changing the sample screen.

[mzazrivec]

@himdel We can discuss what the sample screen should behave and I don't have problem with changing it, though since this is meant to land in ivanchuk, for the PR, I want to go with a non-invasive fix.

[miq-bot]

Checked commit mzazrivec@3f7eddf with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[himdel]

Yeah, we can always do that separately :) (It's just that many more things won't "work" on that screen, automate does not get run so no dynamic fields, it's not actually running the dialog user code, so the default field logic is ..simpler, it does not look similar, etc. So there may be more BZs incoming :).)

[simaishi]

Jansa backport details:

$ git log -1
commit 7b369400f00d96af015e1818e549c9e322b425e8
Author: Martin Hradil <[email protected]>
Date:   Mon Jun 15 14:29:26 2020 +0000

    Merge pull request #7121 from mzazrivec/allow_to_select_full_hour_in_dialog_sample_screen

    Allow to select whole hour in dialog sample screen

    (cherry picked from commit 6967ad8e85931080d1acd9a6c6a94cb069edfca9)

[simaishi]

Ivanchuk backport details:

$ git log -1
commit 12523370d32b662bffa8860823b48e2f96509f6e
Author: Martin Hradil <[email protected]>
Date:   Mon Jun 15 14:29:26 2020 +0000

    Merge pull request #7121 from mzazrivec/allow_to_select_full_hour_in_dialog_sample_screen

    Allow to select whole hour in dialog sample screen

    (cherry picked from commit 6967ad8e85931080d1acd9a6c6a94cb069edfca9)

    https://bugzilla.redhat.com/show_bug.cgi?id=1706848