Make containers dashboard a shareable view and fix wrong pf-utilization-trend-chart directive #7296
Conversation
|
don't you need to change it here as well? |
zeari
force-pushed
the
fix_dashboard_donut_trends
branch
from
a85e6f6 to
ca4adc1
Compare
Good catch! |
|
you might want to do a shareable file with common code and include it in both files, PRs such as this are quite an example why it would be a good idea to do it. less chance to forget, less need for copy paste. |
|
Would be great to have the common code unified, but as for this PR, looks good :) (Also, seems like |
…rs dashboard for new pf version
zeari
force-pushed
the
fix_dashboard_donut_trends
branch
from
ca4adc1 to
d764ad5
Compare
|
pls change the title to reflect what this PR does (2 changes now). |
zeari
changed the title
| @@ -0,0 +1,125 @@ | |||
| .container-fluid.container-tiles-pf.containers-dashboard.miq-dashboard-view{"ng-app" => "containerDashboard", | |||
There was a problem hiding this comment.
.containers-dashboard in show.html.haml but .single-provider-containers-dashboard in _show_dashboard.html.haml
There was a problem hiding this comment.
.containers-dashboard in show.html.haml but .single-provider-containers-dashboard in _show_dashboard.html.haml
Right. Thats hard to fix without #6981. We will know what to do when we will have those images\icons.
There was a problem hiding this comment.
Oh, that's right.. can you (or @abonas ?) reply to Eric there? I'm almost sure we do want font icons but maybe I'm wrong?
There was a problem hiding this comment.
Either way, an alternative would be to make the shared partial only from line 9 on ..but yeah, that has its own problems :)
There was a problem hiding this comment.
Oh, that's right.. can you (or @abonas ?) reply to Eric there? I'm almost sure we do want font icons but maybe I'm wrong?
I dont think thats up to us :\
There was a problem hiding this comment.
I'm pretty sure @epwinchell was asking about the actual practical limitations..
Make containers dashboard a shareable view and fix wrong pf-utilization-trend-chart directive
change
pf-utilization-charttopf-utilization-trend-chartin containers dashboard.there was a name change in the new PF version.
Before:
After(notice the donut is now aligned to the left):
@miq-bot add_label bug, ui, providers/containers
Please review @himdel @abonas
cc @simon3z