Missing openshift and k8s icons from topology and dashboard

[abonas]

On latest master (potentially related to #6957), k8s and openshift icons are missing:

cc @zeari @Fryguy @himdel @skateman @epwinchell - is this because of the latest patternfly? should those icons be added to miq repo similar to Atomic icons?
@miq-bot add_label ui, providers/containers, bug

[skateman]

AFAIK these icons were removed from patternfly, but @serenamarie125 can tell you maybe more. Anyway @epwinchell can probably add the icons to our repo.

[abonas]

yep : patternfly/patternfly@37a1558

[chessbyte]

cc @dclarizio

[abonas]

any update on this from anyone?

[epwinchell]

@serenamarie125 Patternfly removed k8s and open shift icons for the reasons we discussed. Should we add them to our own custom font set or should SVGs and PNGs be used for all vendor images going forward?

cc: @abonas

[abonas]

@epwinchell how is this case different from the Atomic icons that are already part of miq?

[epwinchell]

@abonas Waiting for a definitive answer about whether we can even continue to have those as font icons rather than PNGs and SVGs.

[epwinchell]

@abonas Patternfly 3.3.3 was released today with new branded SVG images for Kubernetes, OpenShift and Atomic. As soon as @skateman can get it converted to sass, we'll merge it in and I'll follow it up with additional SVGs for other vendors. I'll keep you posted.

[abonas]

@abonas Patternfly 3.3.3 was released today with new branded SVG images for Kubernetes, OpenShift and Atomic. As soon as @skateman can get it converted to sass, we'll merge it in and I'll follow it up with additional SVGs for other vendors. I'll keep you posted.

thanks. I need to see if/how it can be added to topology as svg, as the rest of the icons there are text icons, and the topology itself is one big svg.

[epwinchell]

@abonas The first batch of SVGs have been merged here: #7398

[abonas]

@abonas The first batch of SVGs have been merged here: #7398

@epwinchell yes, I saw, thanks for that.
I'm trying to understand how to access them in an html image element, so far any path I tried results with 404. for example, for vendor-kubernetes.svg, what's the right way to access it? I tried to access full path from /assets.... , or shorten to partial path that starts with /images... or /svg, all of the variations return 404.

[himdel]

@abonas image_path('svg/vendor-amazon.svg') (and yes, the image path needs to come from ruby side)

[abonas]

@abonas image_path('svg/vendor-amazon.svg') (and yes, the image path needs to come from ruby side)

thanks @himdel but I'm not sure what you mean. I build the icons data in the js controller, it's not coming from ruby side. mostly because 90% of the icons are text icons and they are on js side, they have nothing to do with ruby. those provider svg icons are now an (inconvenient) exception to the rule.

[himdel]

Yes, but you will have to send it from the server side, it is impossible to generate the url correctly in JS.

Why did you end up going the svg route instead of putting them in the product icon font?

[abonas]

Yes, but you will have to send it from the server side, it is impossible to generate the url correctly in JS.

oh, that will be so not generic and ugly, just for the provider entity...

Why did you end up going the svg route instead of putting them in the product icon font?

it was not my decision. it was instructed to be removed by branding just for the product/project icons.

[epwinchell]

@himdel decision by UXD to use SVGs or PNG going forward for all vendors for branding reasons (monochrome icons aren't acceptable for many vendors - we need full color)

[abonas]

@himdel I would send everything from server side, including the textual icons code, but I clearly remember that for some reason that didn't work. so now I will have to somehow send only provider icons from server, and the rest of the icons from js. 👎 👎 👎

[himdel]

@epwinchell aah, thanks :) understood

@abonas yeah, I'd be all 👍 👍 for sending all of them from the server side .. do you remember why it didn't work? It should..

[abonas]

@abonas yeah, I be all for sending all of them from the server side .. do you remember why it didn't work? It should..

I don't remember, it was several months ago, but I will try to reproduce now and if it still doesn't work, will post here

[himdel]

Sure, thanks, I should be here :)

[abonas]

I reproduced it again, this is how it looks when it is served from server (just sending exactly the same string from the server side) - changed it only for one icon here so you can see the difference.