Revive the plugin inflection test as a skipped test #21524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It all works but we don't have a plugin that has inflections now that v2v is gone. The test is good but we can't run it without a generic plugin that does this. Followup to ManageIQ#21515
|
Thanks @jrafanie @agrare, in discussing this with @jrafanie, I had an idea. What do you think about including the dummy provider as a development/test dependency only? Then we can hang things in there where we need a provider implementation for specs, but really don't want to rely on an actual provider. WDYT? |
Fryguy
approved these changes
Oct 27, 2021
|
Checked commit jrafanie@8a153b3 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
|
Yeah we can do that, it wont be as flexible as stubbing supports. Also wonder if we could allow creation of non-leaf classes in test (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It all works but we don't have a plugin that has inflections now that v2v is
gone. The test is good but we can't run it without a generic plugin that does
this.
Followup to #21515