Delete v2v models, settings, product features, artifacts. #21515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of ManageIQ#21379 We'll drop the model code in a followup PR. Note, no other manageiq rails engine has inflections so the test was removed.
jrafanie
requested review from
agrare,
bdunne,
Fryguy and
kbrock
as code owners
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 22, 2021
From Pull Request: ManageIQ/manageiq#21515
|
@jrafanie 'cross-repo-test(s)' was given invalid repo names and cannot continue
|
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 22, 2021
From Pull Request: ManageIQ/manageiq#21515
jrafanie
force-pushed
the
drop_v2v_backend_code
branch
from
76b60ef to
6118be9
Compare
jrafanie
force-pushed
the
drop_v2v_backend_code
branch
from
6118be9 to
9caa7f0
Compare
|
Checked commits jrafanie/manageiq@7188342~...9caa7f0 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Oct 26, 2021
From Pull Request: ManageIQ/manageiq#21515
jrafanie
commented
Oct 26, 2021
| @@ -39,14 +39,6 @@ | |||
| expect(asset_path.path).to eq ManageIQ::UI::Classic::Engine.root | |||
| expect(asset_path.namespace).to eq "manageiq-ui-classic" | |||
| end | |||
|
|
|||
| it "with engines with inflections" do | |||
There was a problem hiding this comment.
Mark this as pending / keep the test.
There was a problem hiding this comment.
I'll resurrect this test in a followup and mark it pending
jrafanie
commented
Oct 26, 2021
| @@ -1141,7 +1133,6 @@ | |||
| :event_streams_purge_interval: 1.day | |||
| :evm_snapshot_delete_delay_for_job_not_found: 1.hour | |||
| :evm_snapshot_interval: 1.hour | |||
| :infra_conversion_dispatcher_interval: 30.seconds | |||
There was a problem hiding this comment.
Delete these settings in settings_changes
There was a problem hiding this comment.
Done in ManageIQ/manageiq-schema#614
jrafanie
commented
Oct 26, 2021
| :message: 'Conversion Host %{op_name} of resource %{op_arg} failed. Please check the logs for further details.' | ||
| :expires_in: 24.hours | ||
| :level: :error | ||
| :audience: global |
There was a problem hiding this comment.
Removed on upgrade in ManageIQ/manageiq-schema#614
jrafanie
changed the title
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Oct 27, 2021
It all works but we don't have a plugin that has inflections now that v2v is gone. The test is good but we can't run it without a generic plugin that does this. Followup to ManageIQ#21515
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Dec 16, 2021
Fixes ManageIQ/manageiq-ui-classic#7994 Ironically, they were neglected when we added v2v and added later in commit 53e764f Of course, I missed them when removing v2v in: ManageIQ#21515 Which was part of the larger issue: ManageIQ#21379
kbrock
pushed a commit
to kbrock/manageiq
that referenced
this pull request
Jan 10, 2022
Fixes ManageIQ/manageiq-ui-classic#7994 Ironically, they were neglected when we added v2v and added later in commit 53e764f Of course, I missed them when removing v2v in: ManageIQ#21515 Which was part of the larger issue: ManageIQ#21379
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
It all works but we don't have a plugin that has inflections now that v2v is gone. The test is good but we can't run it without a generic plugin that does this. Followup to ManageIQ#21515
GilbertCherrie
pushed a commit
to GilbertCherrie/manageiq
that referenced
this pull request
Jul 7, 2023
Fixes ManageIQ/manageiq-ui-classic#7994 Ironically, they were neglected when we added v2v and added later in commit 53e764f Of course, I missed them when removing v2v in: ManageIQ#21515 Which was part of the larger issue: ManageIQ#21379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21379
Includes #21499
Rebases and adds some things that were missed from #20246