Features to support Event explorer De-explorization #20947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
added a commit
to h-kataria/manageiq-schema
that referenced
this pull request
Jan 12, 2021
If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947
Added `miq_event_show_list` and `miq_event_show` product features for Events ManageIQ/manageiq-ui-classic#6819
h-kataria
force-pushed
the
event_de-explorization
branch
from
93825dd to
dc47fda
Compare
|
Checked commits h-kataria/manageiq@dc47fda~...8c3ab24 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint app/models/miq_policy.rb
|
|
@gtanzillo please review, applied suggested changes to get filtered Events list. |
gtanzillo
reviewed
Jan 19, 2021
| @@ -355,6 +355,22 @@ def self.all_policy_events | |||
| MiqEventDefinition.all_events.select { |e| !e.memberof.empty? && !EVENT_GROUPS_EXCLUDED.include?(e.memberof.first.name) } | |||
| end | |||
|
|
|||
| def self.all_policy_events_filter | |||
| # Todo Convert to SQL if possible | |||
There was a problem hiding this comment.
@kbrock Can you take a look at this expression we came up with to get the list of seeded policy event definitions and see if it can be done in pure SQL? This new code creates a filter expression that can be used in a view, driven by reporting, get the same output this method returns.
There was a problem hiding this comment.
@kbrock Can you look/comment on ^^ when you get a chance, thanks
kbrock
reviewed
Feb 1, 2021
| @@ -14,6 +14,11 @@ class MiqEventDefinition < ApplicationRecord | |||
| has_many :miq_policy_contents | |||
| has_many :policy_events | |||
|
|
|||
| virtual_column :event_group_name, :type => :string | |||
There was a problem hiding this comment.
fyi for those following
acts_as_miq_set_member introduced :memberof
- make memberof an association
- introduce
has_onefor the association (basically same as Move ftp upload methods to file depot #1 but with a has_one instead) - turn into a delegate
has_one :event_group ... memberof viritual_delegate :name, :prefix_true, :allow_nil => true, :to => "event_group"
gtanzillo
approved these changes
Feb 1, 2021
|
why did we merge a PR prefixed with [WIP]? |
h-kataria
changed the title
h-kataria
added a commit
to h-kataria/manageiq-schema
that referenced
this pull request
Feb 5, 2021
If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947
h-kataria
added a commit
to h-kataria/manageiq-schema
that referenced
this pull request
Feb 8, 2021
If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
miq_event_show_listandmiq_event_showproduct features for EventsManageIQ/manageiq-ui-classic#6819
Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.
Guidelines:
Links [Optional]
Steps for Testing/QA [Optional]
If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.