Event Explorer De-Explorization #7569

h-kataria · 2021-01-11T23:48:39Z

Dependent core PR & PR
Data Migration PR
Cross-Repo PR

If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947

skateman · 2021-01-13T12:14:41Z

Just a rebase please, to catch RBAC issues...

skateman · 2021-01-18T08:58:47Z

Crashes on report_data:

[----] F, [2021-01-18T09:58:15.851647 #340101:3a78444] FATAL -- : Error caught: [ActiveRecord::StatementInvalid] PG::UndefinedColumn: ERROR:  column event_streams.description does not exist
LINE 1: ...reams" WHERE "event_streams"."type" = $1 ORDER BY "event_str...
                                                             ^

/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `prepare'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `block in prepare_statement'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:739:in `prepare_statement'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:684:in `exec_cache'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:658:in `execute_and_clear'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in `exec_query'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/database_statements.rb:493:in `select_prepared'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/database_statements.rb:68:in `select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `block in select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:122:in `block in cache_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:113:in `cache_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/querying.rb:46:in `find_by_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:821:in `block in exec_queries'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:839:in `skip_query_cache_if_necessary'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:808:in `exec_queries'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:626:in `load'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:250:in `records'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:245:in `to_ary'
/home/skateman/Repositories/ManageIQ/manageiq/app/models/miq_report/generator.rb:411:in `build_table'
/home/skateman/Repositories/ManageIQ/manageiq/app/models/miq_report/search.rb:127:in `paged_view_search'
/home/skateman/Repositories/ManageIQ/manageiq-ui-classic/app/controllers/application_controller.rb:1247:in `get_view'
/home/skateman/Repositories/ManageIQ/manageiq-ui-classic/app/controllers/application_controller.rb:363:in `report_data'

h-kataria · 2021-01-18T18:14:46Z

Crashes on report_data:

[----] F, [2021-01-18T09:58:15.851647 #340101:3a78444] FATAL -- : Error caught: [ActiveRecord::StatementInvalid] PG::UndefinedColumn: ERROR:  column event_streams.description does not exist
LINE 1: ...reams" WHERE "event_streams"."type" = $1 ORDER BY "event_str...
                                                             ^

/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `prepare'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:744:in `block in prepare_statement'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:739:in `prepare_statement'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:684:in `exec_cache'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:658:in `execute_and_clear'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql/database_statements.rb:98:in `exec_query'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/database_statements.rb:493:in `select_prepared'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/database_statements.rb:68:in `select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `block in select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:122:in `block in cache_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activesupport-6.0.3.4/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:113:in `cache_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/abstract/query_cache.rb:105:in `select_all'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/querying.rb:46:in `find_by_sql'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:821:in `block in exec_queries'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:839:in `skip_query_cache_if_necessary'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:808:in `exec_queries'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:626:in `load'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:250:in `records'
/home/skateman/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:245:in `to_ary'
/home/skateman/Repositories/ManageIQ/manageiq/app/models/miq_report/generator.rb:411:in `build_table'
/home/skateman/Repositories/ManageIQ/manageiq/app/models/miq_report/search.rb:127:in `paged_view_search'
/home/skateman/Repositories/ManageIQ/manageiq-ui-classic/app/controllers/application_controller.rb:1247:in `get_view'
/home/skateman/Repositories/ManageIQ/manageiq-ui-classic/app/controllers/application_controller.rb:363:in `report_data'

fixed

gtanzillo · 2021-02-01T22:49:26Z

@h-kataria It looks like the back arrow is not working when viewing the details of an event. When I click it nothing happens. But it does make a trip to the server. I didn't see any errors in the log nor the web console.

h-kataria · 2021-02-02T00:09:58Z

@h-kataria It looks like the back arrow is not working when viewing the details of an event. When I click it nothing happens. But it does make a trip to the server. I didn't see any errors in the log nor the web console.

Fixed. That button should not have been present on the summary screen.

gtanzillo

I tested locally and everything is working as expected 👍

h-kataria · 2021-02-02T17:05:00Z

@skateman please review

app/views/miq_event/show.html.haml

config/routes.rb

skateman · 2021-02-03T07:47:17Z

product/views/MiqEvent.yaml

@@ -15,25 +15,31 @@ title: Events
 name: Event

 # Main DB table report is based on
-db: MiqEvent
+db: MiqEventDefinition


Umm, it's a little confusing, the controller is miq_event but the model is miq_event_definition. Shouldn't we try to increase consistency?

If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947

h-kataria · 2021-02-05T22:11:43Z

@miq-bot cross_repo_tests manageiq-api, manageiq-ui-classic including manageiq-schema#550 manageiq#21016

From Pull Request: ManageIQ/manageiq-ui-classic#7569

Changes to support Events related screens as other normal screens in the product to help support direct linking.

Pre work for ManageIQ#7401

Made changes to list view coe to expect and pass filter back to report_data method. Pre work for ManageIQ#7401

- Back button is to go back to summary screen, is displayed on sub-screens that are linked from summary screen. UI PR ManageIQ#7401 for ManageIQ#6819

- and some cleanup to show_list method

h-kataria · 2021-02-05T22:27:32Z

@skateman please re-review

miq-bot · 2021-02-05T22:36:06Z

Checked commits h-kataria/manageiq-ui-classic@0c93992~...fbc1f7f with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
14 files checked, 6 offenses detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby26, which recognizes
warning: 2.6.6-compliant syntax, but you are running 2.6.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

app/controllers/application_controller.rb

❗ - Line 1138, Col 18 - Layout/ExtraSpacing - Unnecessary spacing detected.
❗ - Line 1138, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

app/controllers/application_controller/report_data_additional_options.rb

⚠️ - Line 9, Col 5 - Lint/StructNewOverride - :filter member overrides Struct#filter and it may be unexpected.

app/controllers/miq_event_definition_controller.rb

❗ - Line 37, Col 7 - Naming/AccessorMethodName - Do not prefix reader method names with get_.

app/presenters/menu/default_menu.rb

❗ - Line 231, Col 141 - Layout/ExtraSpacing - Unnecessary spacing detected.

skateman · 2021-02-08T06:44:32Z

Code looks fine.

If any of the users had their startpage set to Policy Events explorer screen, this migration sets it to non-explorer version screen of Policy Events list view. UI PR ManageIQ/manageiq-ui-classic#7569 Core PR ManageIQ/manageiq#20947

gtanzillo · 2021-02-08T14:46:49Z

I tested this locally, again and it looks good 👍

h-kataria added enhancement wip pending core labels Jan 11, 2021

h-kataria requested a review from skateman January 11, 2021 23:48

h-kataria assigned skateman Jan 11, 2021

h-kataria mentioned this pull request Jan 11, 2021

Convert explorers to non-explorer style screens #6819

Open

42 tasks

h-kataria mentioned this pull request Jan 12, 2021

Data Migration for Events Startpage url update ManageIQ/manageiq-schema#550

Merged

h-kataria force-pushed the event_de-explorization branch from aef0794 to 930a5e8 Compare January 16, 2021 18:59

miq-bot added the unmergeable label Jan 27, 2021

h-kataria force-pushed the event_de-explorization branch 2 times, most recently from 4285f4c to e2eef81 Compare February 2, 2021 00:15

h-kataria mentioned this pull request Feb 2, 2021

Added missing dictionary entry for 'miq_event' ManageIQ/manageiq#20998

Merged

gtanzillo approved these changes Feb 2, 2021

View reviewed changes

h-kataria removed the wip label Feb 2, 2021

h-kataria changed the title ~~[WIP] - Event Explorer De-Explorization~~ Event Explorer De-Explorization Feb 2, 2021

h-kataria force-pushed the event_de-explorization branch from d225ec2 to e451f38 Compare February 2, 2021 17:04

miq-bot removed the unmergeable label Feb 2, 2021

skateman reviewed Feb 3, 2021

View reviewed changes

app/views/miq_event/show.html.haml Outdated Show resolved Hide resolved

skateman reviewed Feb 3, 2021

View reviewed changes

config/routes.rb Outdated Show resolved Hide resolved

skateman reviewed Feb 3, 2021

View reviewed changes

miq-bot added the unmergeable label Feb 3, 2021

h-kataria added the wip label Feb 5, 2021

h-kataria force-pushed the event_de-explorization branch from e451f38 to 21b2da0 Compare February 5, 2021 21:08

h-kataria removed unmergeable wip labels Feb 5, 2021

h-kataria force-pushed the event_de-explorization branch from 4645214 to 399c972 Compare February 5, 2021 21:31

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 5, 2021

Running tests for h-kataria

69673cb

From Pull Request: ManageIQ/manageiq-ui-classic#7569

miq-bot mentioned this pull request Feb 5, 2021

[BOT] Cross repo test for ManageIQ/manageiq-ui-classic#7569 ManageIQ/manageiq-cross_repo-tests#296

Closed

h-kataria added 5 commits February 5, 2021 17:15

Event Explorer De-Explorization

0c93992

Changes to support Events related screens as other normal screens in the product to help support direct linking.

fixed routes_spec failure

e137b33

Pre work for ManageIQ#7401

Changes to pass in filter to search to get specific events only

c00ecdb

Made changes to list view coe to expect and pass filter back to report_data method. Pre work for ManageIQ#7401

Fixed to not show "Back" button on summary screen and fixed breadcrumb.

775b7ae

- Back button is to go back to summary screen, is displayed on sub-screens that are linked from summary screen. UI PR ManageIQ#7401 for ManageIQ#6819

Fixed breadcrumbs to show link for Events on details screen

7b4764f

- and some cleanup to show_list method

h-kataria force-pushed the event_de-explorization branch from 399c972 to c8983f1 Compare February 5, 2021 22:15

Renamed miq_event related files to miq_event_definition for consistency

fbc1f7f

h-kataria force-pushed the event_de-explorization branch from c8983f1 to fbc1f7f Compare February 5, 2021 22:35

h-kataria closed this Feb 8, 2021

h-kataria reopened this Feb 8, 2021

gtanzillo merged commit 6118b83 into ManageIQ:master Feb 8, 2021

gtanzillo self-assigned this Feb 8, 2021

chessbyte mentioned this pull request Feb 23, 2021

[Lasker] Convert explorers to non-explorer style screens #7641

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event Explorer De-Explorization #7569

Event Explorer De-Explorization #7569

h-kataria commented Jan 11, 2021 •

edited by chessbyte

Loading

skateman commented Jan 13, 2021

skateman commented Jan 18, 2021

h-kataria commented Jan 18, 2021

gtanzillo commented Feb 1, 2021

h-kataria commented Feb 2, 2021

gtanzillo left a comment

h-kataria commented Feb 2, 2021

skateman Feb 3, 2021

h-kataria commented Feb 5, 2021

h-kataria commented Feb 5, 2021

miq-bot commented Feb 5, 2021

skateman commented Feb 8, 2021

gtanzillo commented Feb 8, 2021

Event Explorer De-Explorization #7569

Event Explorer De-Explorization #7569

Conversation

h-kataria commented Jan 11, 2021 • edited by chessbyte Loading

skateman commented Jan 13, 2021

skateman commented Jan 18, 2021

h-kataria commented Jan 18, 2021

gtanzillo commented Feb 1, 2021

h-kataria commented Feb 2, 2021

gtanzillo left a comment

Choose a reason for hiding this comment

h-kataria commented Feb 2, 2021

skateman Feb 3, 2021

Choose a reason for hiding this comment

h-kataria commented Feb 5, 2021

h-kataria commented Feb 5, 2021

miq-bot commented Feb 5, 2021

skateman commented Feb 8, 2021

gtanzillo commented Feb 8, 2021

h-kataria commented Jan 11, 2021 •

edited by chessbyte

Loading