Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chargeback Reports De-Explorization support #20190

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Chargeback Reports De-Explorization support #20190

merged 2 commits into from
Jun 1, 2020

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented May 20, 2020 •
edited
Loading

Added scope to get chargeback* reports on Chargeback Reports list view

Feature changes

Existing Feature Updated Feature New Feature
chargeback_download_csv chargeback_reports_download_csv
chargeback_download_pdf chargeback_reports_download_pdf
chargeback_download_text chargeback_reports_download_text
chargeback_report_only chargeback_reports_report_only
chargeback_reports_view
chargeback_reports_show_list
chargeback_reports_show

@h-kataria h-kataria requested a review from kbrock as a code owner May 20, 2020 02:23
@h-kataria h-kataria mentioned this pull request May 20, 2020
Merged
@gtanzillo gtanzillo mentioned this pull request May 20, 2020
Closed
12 tasks
@h-kataria h-kataria requested review from agrare and bdunne as code owners May 20, 2020 02:47
@h-kataria h-kataria force-pushed the cb_reports_non_explorer branch 3 times, most recently from 6167630 to 2f63e8e Compare May 20, 2020 21:01
@h-kataria h-kataria mentioned this pull request May 20, 2020
Merged
@h-kataria h-kataria force-pushed the cb_reports_non_explorer branch from 2f63e8e to b8b45b5 Compare May 21, 2020 00:39
@h-kataria h-kataria removed the wip label May 21, 2020
@h-kataria h-kataria changed the title [WIP] Chargeback Reports De-Explorization support Chargeback Reports De-Explorization support May 21, 2020
h-kataria added 2 commits May 22, 2020 09:39
@h-kataria
Added/Updated existing chargeback reports features
75ff258 
- Added new features for list/show tasks.
- Updated features ids of existing features to match new controller name.
@h-kataria
Updated start page url for chargeback reports and feature id for the url
502e9a0
@h-kataria h-kataria force-pushed the cb_reports_non_explorer branch from b8b45b5 to 502e9a0 Compare May 22, 2020 13:40
@miq-bot
Copy link
Member

miq-bot commented May 22, 2020

Checked commits h-kataria/manageiq@75ff258~...502e9a0 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

skateman
skateman approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

kbrock
kbrock approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

Who tends to map out the product features matrix to ensure we're going towards a sane standard?

@Fryguy Fryguy merged commit d452e41 into ManageIQ:master Jun 1, 2020
simaishi pushed a commit that referenced this pull request Jun 1, 2020
@Fryguy @simaishi
Merge pull request #20190 from h-kataria/cb_reports_non_explorer
3d155bf 
Chargeback Reports De-Explorization support

(cherry picked from commit d452e41)
@simaishi
Copy link
Contributor

simaishi commented Jun 1, 2020

Jansa backport details:

$ git log -1
commit 3d155bf3cbe042b5cf09d4abba9a219684051b17
Author: Jason Frey <[email protected]>
Date:   Mon Jun 1 10:59:32 2020 -0400

    Merge pull request #20190 from h-kataria/cb_reports_non_explorer

    Chargeback Reports De-Explorization support

    (cherry picked from commit d452e41fcf37dcc6c726a7e9659f176629666985)

@h-kataria h-kataria deleted the cb_reports_non_explorer branch December 31, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

@kbrock kbrock kbrock approved these changes

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@skateman skateman

Labels
enhancement jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@h-kataria @miq-bot @simaishi @kbrock @skateman @Fryguy @chessbyte