Chargeback Reports features and startpage data migrations #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
h-kataria
force-pushed
the
cb_reports_startpage_update
branch
from
4bfdbe2 to
700824b
Compare
skateman
suggested changes
May 22, 2020
db/migrate/20200520211047_adjust_chargeback_reports_features.rb
Outdated
Show resolved
Hide resolved
db/migrate/20200520211047_adjust_chargeback_reports_features.rb
Outdated
Show resolved
Hide resolved
h-kataria
force-pushed
the
cb_reports_startpage_update
branch
from
700824b to
878ca0b
Compare
Fryguy
reviewed
May 22, 2020
spec/migrations/20200520211047_adjust_chargeback_reports_features_spec.rb
Outdated
Show resolved
Hide resolved
h-kataria
force-pushed
the
cb_reports_startpage_update
branch
from
878ca0b to
e8f034a
Compare
Fryguy
requested changes
May 22, 2020
Fryguy
reviewed
May 22, 2020
db/migrate/20200520211047_adjust_chargeback_reports_features.rb
Outdated
Show resolved
Hide resolved
Previous commit was adding multiple records of same `chargeback_Report_view`. Cleaned up test a bit to verify the total counts. Added a spec test to verify that down migration is skipped when there are no role features set for user.
h-kataria
force-pushed
the
cb_reports_startpage_update
branch
from
3609f7e to
b7108ad
Compare
|
@Fryguy please re-review |
Fryguy
reviewed
Jun 1, 2020
spec/migrations/20200520211047_adjust_chargeback_reports_features_spec.rb
Show resolved
Hide resolved
Adjusted test to verify that product features are renamed even when there are no MiqRoleFeatures.
h-kataria
force-pushed
the
cb_reports_startpage_update
branch
from
3baef88 to
19856e9
Compare
|
Checked commits h-kataria/manageiq-schema@6925a48~...19856e9 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Fryguy
approved these changes
Jun 1, 2020
simaishi
pushed a commit
that referenced
this pull request
Jun 1, 2020
Chargeback Reports features and startpage data migrations (cherry picked from commit 3a66ffb)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data migration changes for product feature changes and startpage changes in ManageIQ/manageiq#20190
UI PR ManageIQ/manageiq-ui-classic#7058