Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run worker pods as root #20095

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

carbonin
Copy link
Member

A bunch of certifications require us not to run as root
in containers. Additionally the vast majority of the application
should run fine without root and the parts that need root are
typically things we can't do in containers anyway.

Related to ManageIQ/manageiq-pods#442

Merge with ManageIQ/manageiq-pods#466

A bunch of certifications require us not to run as root
in containers. Additionally the vast majority of the application
should run fine without root and the parts that need root are
typically things we can't do in containers anyway.
@miq-bot
Copy link
Member

miq-bot commented Apr 23, 2020

Checked commit carbonin@7fce34b with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit 78cecce into ManageIQ:master Apr 24, 2020
@bdunne bdunne assigned bdunne and unassigned Fryguy Apr 24, 2020
simaishi pushed a commit that referenced this pull request May 1, 2020
Don't run worker pods as root

(cherry picked from commit 78cecce)
@simaishi
Copy link
Contributor

simaishi commented May 1, 2020

Jansa backport details:

$ git log -1
commit a9116583dd8eb86f6f0f947b5769fc9b89e5b853
Author: Brandon Dunne <[email protected]>
Date:   Fri Apr 24 14:46:09 2020 -0400

    Merge pull request #20095 from carbonin/dont_run_pods_as_root

    Don't run worker pods as root

    (cherry picked from commit 78cecce6e0a3954d3d14f3b270e0c39ab057b9ea)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants