Don't run the app as root #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of certifications require us not to run as root in containers. Additionally the vast majority of the application should run fine without root and the parts that need root are typically things we can't do in containers anyway. Specifically this changes the permissions of some directories to allow the root group access which is what we'll be running as when using the restricted scc in OpenShift
|
Checked commit carbonin@91248cd with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint **
|
bdunne
approved these changes
Apr 24, 2020
simaishi
pushed a commit
that referenced
this pull request
May 1, 2020
Don't run the app as root (cherry picked from commit 4208109)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This makes the orchestrator and work pods run in the restricted scc rather than anyuid
A bunch of certifications require us not to run as root
in containers. Additionally the vast majority of the application
should run fine without root and the parts that need root are
typically things we can't do in containers anyway.
Specifically this changes the permissions of some directories to
allow the root group access which is what we'll be running as when
using the restricted scc in OpenShift
Related to #442
Special notes for your reviewer:
Merge with ManageIQ/manageiq#20095