Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rubocop gone bad #20044

Merged
merged 1 commit into from
Apr 2, 2020
Merged

fix rubocop gone bad #20044

merged 1 commit into from
Apr 2, 2020

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 2, 2020 •
edited
Loading

To fix a rubocop, we swapped the wrong where clause and caused a syntax error.
This fixes the syntax error.

introduced by #19824

@kbrock kbrock requested review from agrare and Fryguy as code owners April 2, 2020 19:13
@Fryguy Fryguy self-assigned this Apr 2, 2020
@bdunne bdunne merged commit 63b3608 into ManageIQ:master Apr 2, 2020
@bdunne bdunne assigned bdunne and unassigned Fryguy Apr 2, 2020
@bdunne
Copy link
Member

bdunne commented Apr 2, 2020

Merged while red because this needs ManageIQ/manageiq-automation_engine#425 and it needs this PR to go green.

@lfu lfu mentioned this pull request Apr 2, 2020
Merged
@kbrock kbrock deleted the ancestry_v2 branch April 2, 2020 20:03
@lfu lfu mentioned this pull request Apr 3, 2020
Merged
simaishi pushed a commit that referenced this pull request Apr 16, 2020
@bdunne @simaishi
Merge pull request #20044 from kbrock/ancestry_v2
db7a207 
fix rubocop gone bad

(cherry picked from commit 63b3608)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit db7a207645a24753b2d90753324dd9ec6523c24d
Author: Brandon Dunne <[email protected]>
Date:   Thu Apr 2 15:18:33 2020 -0400

    Merge pull request #20044 from kbrock/ancestry_v2

    fix rubocop gone bad

    (cherry picked from commit 63b3608c8d828c8579a835bea313d521b0be3cc3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne approved these changes

@Fryguy Fryguy Fryguy approved these changes

@agrare agrare Awaiting requested review from agrare agrare is a code owner

Assignees

@bdunne bdunne

Labels
bug core jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kbrock @bdunne @simaishi @Fryguy