MiqAeNamespace should use ancestry instead of acts_as_tree #19824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
2 times, most recently
from
9b338f1 to
fc546ae
Compare
Fryguy
reviewed
Feb 10, 2020
Fryguy
reviewed
Feb 10, 2020
Fryguy
reviewed
Feb 10, 2020
|
Can you run a cross repo test will all of the different branches you have? |
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
2 times, most recently
from
fb0c7df to
2cc1456
Compare
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
from
2cc1456 to
f6bf756
Compare
kbrock
reviewed
Mar 24, 2020
There was a problem hiding this comment.
Ancestry is great when you are on a node and want to traverse all children / all parents.
But if all you want ancestry to do is to store a hierarchical key, then a basic string column will do it all and not require any other schema changes.
You now the use case better than I - so only you can say if you need to do children / parents / siblings and stuff like that.
kbrock
reviewed
Mar 25, 2020
Closed
4 tasks
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
from
f6bf756 to
2e23b6a
Compare
kbrock
approved these changes
Mar 31, 2020
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
from
2e23b6a to
883149b
Compare
lfu
force-pushed
the
add_ancestry_to_miq_ae_namespace
branch
from
883149b to
a6c5b9e
Compare
|
Checked commit lfu@a6c5b9e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
Merged
simaishi
pushed a commit
that referenced
this pull request
Apr 16, 2020
MiqAeNamespace should use ancestry instead of acts_as_tree (cherry picked from commit 75f60ba)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #20044.
Depends on ManageIQ/manageiq-schema#455.
Related to ManageIQ/manageiq-automation_engine#425.
Related to ManageIQ/manageiq-ui-classic#6668.Cross Repo Tests: ManageIQ/manageiq-cross_repo-tests#66
ManageIQ/manageiq-automation_engine#409
@miq-bot add_label performance, automate, changelog/yes