Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix report formatter deprecation warning #20037

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Apr 1, 2020

DEPRECATION WARNING: ReportFormatter::ReportRenderer is deprecated!
Use ManageIQ::Reporting::Formatter::ReportRenderer instead.

I don't understand the implications of this change.
I'll tag as ui because they probably know more about this

DEPRECATION WARNING: ReportFormatter::ReportRenderer is deprecated!
Use ManageIQ::Reporting::Formatter::ReportRenderer instead.
@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2020

Checked commit kbrock@33b2df9 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@jrafanie
Copy link
Member

jrafanie commented Apr 2, 2020

This was caused by me intentionally, when I fixed #19674 in PR: #19873

@jrafanie
Copy link
Member

jrafanie commented Apr 2, 2020

I wonder why I missed this one. 🤷‍♂

@jrafanie jrafanie merged commit 369433b into ManageIQ:master Apr 2, 2020
@jrafanie jrafanie self-assigned this Apr 2, 2020
@kbrock kbrock deleted the report_formatter_change branch April 2, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants