Move report formatter and charting to core

[jrafanie]

• Cross repo tests - Test the move of report_formatter and charting to core manageiq-cross_repo-tests#74
• Must be merged with the ui-classic PR

Note, for happy reviewing, please review the main part of the PR in commit "Namespace all the things." without whitespace changes.

This and the UI classic PR resolves: #19674 (missing ReportFormatter for backend workers)

Also, related to #19863 (move code from UI-classic that can be called from either the frontend or backend

Thanks @bdunne for some guidance on naming things and deciding if this be should a plugin or not (tldr; too many current references to classes embedded in this code so we can't plugin-ize yet)

Also, this might help visualize the layout.

Before, in ui-classic:

lib
├── charting
│   └── c3_charting.rb
├── charting.rb
...
├── report_formatter
│   ├── c3.rb
│   ├── c3_series.rb
│   ├── chart_common.rb
│   ├── converter.rb
│   ├── html.rb
│   ├── report_renderer.rb
│   ├── text.rb
│   ├── timeline.rb
│   └── timeline_message.rb
├── report_formatter.rb
...

After, in core:

lib
...
├── charting.rb # Deprecate old Charting
├── manageiq
    ...
│   ├── reporting
│   │   ├── charting
│   │   │   └── c3_charting.rb
│   │   ├── charting.rb
│   │   ├── formatter
│   │   │   ├── c3.rb
│   │   │   ├── c3_helper.rb
│   │   │   ├── c3_series.rb
│   │   │   ├── chart_common.rb
│   │   │   ├── converter.rb
│   │   │   ├── html.rb
│   │   │   ├── report_renderer.rb
│   │   │   ├── text.rb
│   │   │   ├── timeline.rb
│   │   │   └── timeline_message.rb
│   │   └── formatter.rb
    ...
...
├── report_formatter.rb. # Deprecate old ReportFormatter

[jrafanie]

cc @PanSpagetka

[jrafanie]

Reviewers, let me explain this. Rails has deprecate_constant that you can use by including ActiveSupport::Deprecation::DeprecatedConstantAccessor in your class/module. This is great and works well in the old ReportFormatter, see the lib/manageiq/reporting/formatter.rb. The major benefit is it tells you what is deprecated and what's the new behavior to use.

Unfortunately, you can't include that module globally, and we have two global constants, Charting and ReportFormatter to deprecate. Ruby has deprecate_constant, which we can call on Object to ensure any references to Charting ReportFormatter at the top level do raise deprecations. The ruby version doesn't need to include any modules but it also just tells you it's deprecated without any suggestions as to the solution. I think this is the best we can do. Maybe someone knows something better?

So, here, we setup the old Constant, set to the new one and deprecate the old one.

[jrafanie]

Add @PanSpagetka and I as the reviewers for this directory from a code and code loading side.

[jrafanie]

See comment on lib/charting.rb... same thing is happening here.

[bdunne]

Can you add the typical extraction message to the first commit? Something like:

Extract class MiqReportFormats(transferred from ManageIQ/manageiq@9415b33cf35c72e8cff43c4719f9927500a3f5a2)

[jrafanie]

I updated the description with a before/after file layout tree to help visualize the changes.

[bdunne]

😆 Did you show this 2 @Fryguy ?

[jrafanie]

beautifully_named_methods4the_win

[bdunne]

👋 Bye formater

[miq-bot]

Some comments on commits jrafanie/manageiq@2a4d36a~...bf0bfd4

spec/lib/manageiq/reporting/formatter/c3_spec.rb

• ⚠️ - 21 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 43 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 59 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 69 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 79 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 95 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

spec/lib/manageiq/reporting/formatter/chart_common_spec.rb

• ⚠️ - 4 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 50 - Detected expect_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits jrafanie/manageiq@2a4d36a~...bf0bfd4 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.20.0, and yamllint
26 files checked, 206 offenses detected

lib/charting.rb

• ❗ - Line 6, Col 1 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

lib/manageiq/reporting/charting.rb

• ❗ - Line 6, Col 18 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

lib/manageiq/reporting/charting/c3_charting.rb

• ⚠️ - Line 43, Col 24 - Lint/UnderscorePrefixedVariableName - Do not use prefix _ for a variable that is used.
• ❗ - Line 37, Col 20 - Security/YAMLLoad - Prefer using YAML.safe_load over YAML.load.
• ❗ - Line 45, Col 11 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• ❗ - Line 55, Col 25 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 55, Col 42 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 57, Col 43 - Layout/SpaceAfterComma - Space missing after comma.
• ❗ - Line 57, Col 66 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 72, Col 10 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 80, Col 14 - Security/YAMLLoad - Prefer using YAML.safe_load over YAML.load.
• ❗ - Line 83, Col 21 - Style/MutableConstant - Freeze mutable objects assigned to constants.

lib/manageiq/reporting/formatter.rb

• ❗ - Line 13, Col 21 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 14, Col 14 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 1, Col 1 - Style/MixinUsage - include is used at the top level. Use inside class or module.

lib/manageiq/reporting/formatter/c3.rb

• ❗ - Line 119, Col 11 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 154, Col 43 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 17, Col 25 - Style/MutableConstant - Freeze mutable objects assigned to constants.
• ❗ - Line 99, Col 13 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/manageiq/reporting/formatter/c3_helper.rb

• ❗ - Line 16, Col 1 - Layout/ClosingHeredocIndentation - EOJ is not aligned with javascript_tag(<<~EOJ) or beginning of method definition.
• ❗ - Line 16, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
• ❗ - Line 27, Col 1 - Layout/ClosingHeredocIndentation - EOJ is not aligned with javascript_tag(<<~EOJ) or beginning of method definition.
• ❗ - Line 27, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.

lib/manageiq/reporting/formatter/c3_series.rb

• ❗ - Line 25, Col 13 - Naming/AccessorMethodName - Do not prefix writer method names with set_.

lib/manageiq/reporting/formatter/chart_common.rb

• ⚠️ - Line 91, Col 11 - Lint/UselessAssignment - Useless assignment to variable - cat_total.
• ❗ - Line 141, Col 39 - Layout/MultilineHashBraceLayout - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.
• ❗ - Line 198, Col 15 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 239, Col 41 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 25, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 292, Col 20 - Layout/MultilineMethodCallIndentation - Align .each_with_object with .reverse on line 291.
• ❗ - Line 322, Col 20 - Layout/MultilineMethodCallIndentation - Align .each_with_object with .reverse on line 321.
• ❗ - Line 395, Col 13 - Style/MultilineIfModifier - Favor a normal if-statement over a modifier clause in a multiline statement.
• ❗ - Line 402, Col 37 - Rails/Presence - Use k.presence || _('no value') instead of k.blank? ? _('no value') : k.
• ❗ - Line 412, Col 26 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 434, Col 55 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 456, Col 41 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 460, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 460, Col 72 - Rails/Blank - Use if mri.graph[:column].blank? instead of unless mri.graph[:column].present?.
• ❗ - Line 46, Col 1 - Layout/EmptyLinesAroundBlockBody - Extra empty line detected at block body beginning.
• ❗ - Line 47, Col 13 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 50, Col 28 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 55, Col 47 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 69, Col 15 - Style/NegatedIf - Favor unless over if for negative conditions.
• ❗ - Line 6, Col 23 - Performance/StringReplacement - Use tr instead of gsub.
• ❗ - Line 81, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 95, Col 13 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/manageiq/reporting/formatter/html.rb

• ❗ - Line 20, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/manageiq/reporting/formatter/text.rb

• ⚠️ - Line 212, Col 40 - Lint/ShadowingOuterLocalVariable - Shadowing outer local variable - t.
• ❗ - Line 104, Col 37 - Style/UnneededCondition - Use double pipes || instead.
• ❗ - Line 106, Col 13 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 114, Col 35 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 118, Col 15 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 118, Col 15 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• ❗ - Line 121, Col 65 - Style/UnneededCondition - Use double pipes || instead.
• ❗ - Line 126, Col 18 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 138, Col 19 - Style/IdenticalConditionalBranches - Move s += @hr out of the conditional.
• ❗ - Line 144, Col 19 - Style/IdenticalConditionalBranches - Move s += @hr out of the conditional.
• ❗ - Line 171, Col 14 - Rails/Present - Use mri.user_categories.present? instead of !mri.user_categories.blank?.
• ❗ - Line 171, Col 45 - Rails/Present - Use mri.categories.present? instead of !mri.categories.blank?.
• ❗ - Line 173, Col 13 - Rails/Present - Use if mri.user_categories.present? instead of unless mri.user_categories.blank?.
• ❗ - Line 175, Col 15 - Rails/Present - Use if user_filters.present? instead of unless user_filters.blank?.
• ❗ - Line 188, Col 13 - Rails/Present - Use if mri.categories.present? instead of unless mri.categories.blank?.
• ❗ - Line 190, Col 15 - Rails/Present - Use if categories.present? instead of unless categories.blank?.
• ❗ - Line 19, Col 35 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 205, Col 17 - Style/IdenticalConditionalBranches - Move filter_fields = "Report based filter fields:" out of the conditional.
• ❗ - Line 210, Col 73 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 21, Col 15 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 21, Col 15 - Style/UnlessElse - Do not use unless with else. Rewrite these with the positive case first.
• ❗ - Line 220, Col 17 - Style/IdenticalConditionalBranches - Move output << fit_to_width("|#{t}|" + CRLF) out of the conditional.
• ❗ - Line 222, Col 17 - Style/IdenticalConditionalBranches - Move filter_fields = "Report based filter fields:" out of the conditional.
• ❗ - Line 227, Col 17 - Style/IdenticalConditionalBranches - Move output << fit_to_width("|#{t}|" + CRLF) out of the conditional.
• ❗ - Line 24, Col 65 - Style/UnneededCondition - Use double pipes || instead.
• ❗ - Line 256, Col 11 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 58, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 76, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/manageiq/reporting/formatter/timeline.rb

• ❗ - Line 105, Col 27 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• ❗ - Line 105, Col 28 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 108, Col 15 - Style/NegatedIf - Favor unless over if for negative conditions.
• ❗ - Line 126, Col 36 - Style/UnneededCondition - Use double pipes || instead.
• ❗ - Line 172, Col 13 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 23, Col 48 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
• ❗ - Line 32, Col 11 - Style/ConditionalAssignment - Use the return of the conditional for variable assignment and comparison.
• ❗ - Line 32, Col 41 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 33, Col 69 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 35, Col 31 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 61, Col 33 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 66, Col 61 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
• ❗ - Line 75, Col 31 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 76, Col 11 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
• ❗ - Line 78, Col 62 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 80, Col 107 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 80, Col 62 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 83, Col 123 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 83, Col 38 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 83, Col 82 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.xmlschema, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.httpdate, Time.now.to_i, Time.now.to_f instead.
• ❗ - Line 84, Col 64 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 86, Col 109 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 86, Col 64 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 86, Col 84 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 89, Col 107 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 89, Col 62 - Rails/Date - Do not use to_time on Date objects, because they know nothing about the time zone in use.
• ❗ - Line 89, Col 82 - Style/IfInsideElse - Convert if nested inside else to elsif.
• ❗ - Line 92, Col 23 - Layout/ExtraSpacing - Unnecessary spacing detected.
• ❗ - Line 93, Col 19 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id.

lib/manageiq/reporting/formatter/timeline_message.rb

• ❗ - Line 104, Col 14 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• ❗ - Line 5, Col 33 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 7, Col 43 - Naming/UncommunicativeMethodParamName - Method parameter must be at least 3 characters long.

lib/report_formatter.rb

• ❗ - Line 6, Col 1 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

spec/lib/manageiq/reporting/formatter/c3_spec.rb

• ❗ - Line 103, Col 68 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 103, Col 96 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 130, Col 68 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 130, Col 96 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
• ❗ - Line 157, Col 68 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
• ❗ - Line 157, Col 96 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

spec/lib/manageiq/reporting/formatter/chart_common_spec.rb

• ❗ - Line 22, Col 32 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 25, Col 26 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 35, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 42, Col 28 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 46, Col 26 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

spec/lib/manageiq/reporting/formatter/text_spec.rb

• ❗ - Line 27, Col 1 - Layout/ClosingHeredocIndentation - TABLE is not aligned with expected = <<~TABLE.
• ❗ - Line 48, Col 1 - Layout/ClosingHeredocIndentation - TABLE is not aligned with expected = <<~TABLE.
• ❗ - Line 72, Col 1 - Layout/ClosingHeredocIndentation - TABLE is not aligned with expected = <<~TABLE.

spec/lib/manageiq/reporting/formatter/timeline_spec.rb

• ❗ - Line 101, Col 36 - Layout/AlignArguments - Align the arguments of a method call if they span more than one line.
• ❗ - Line 102, Col 50 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 103, Col 50 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 106, Col 77 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 109, Col 77 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 128, Col 26 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 169, Col 23 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 170, Col 23 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 182, Col 30 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 213, Col 26 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 253, Col 34 - Layout/AlignArguments - Align the arguments of a method call if they span more than one line.
• ❗ - Line 254, Col 48 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 255, Col 48 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 258, Col 75 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 261, Col 75 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 271, Col 24 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 36, Col 26 - Layout/AlignArguments - Align the arguments of a method call if they span more than one line.
• ❗ - Line 61, Col 26 - Layout/AlignArguments - Align the arguments of a method call if they span more than one line.
• ❗ - Line 7, Col 26 - Layout/AlignArguments - Align the arguments of a method call if they span more than one line.

spec/models/miq_widget/chart_content_spec.rb

• ❗ - Line 63, Col 12 - Style/NestedParenthesizedCalls - Add parentheses to nested method call ManageIQ::Reporting::Charting.data_ok? content.contents.

spec/support/report_helper.rb

• ❗ - Line 104, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 105, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 108, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 113, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 117, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 130, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 131, Col 56 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 132, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 135, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 140, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 144, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 148, Col 12 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 156, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 158, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 160, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 167, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 171, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 179, Col 12 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 187, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 189, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 192, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 198, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 19, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 202, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 212, Col 12 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 21, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 220, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 221, Col 52 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 222, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 225, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 235, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 246, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 247, Col 54 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 248, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 251, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 253, Col 55 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 258, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 26, Col 55 - Style/PercentLiteralDelimiters - %i-literals should be delimited by [ and ].
• ❗ - Line 270, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 271, Col 56 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 272, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 275, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 277, Col 57 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 283, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 295, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 296, Col 54 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

[miq-bot]

...continued

• ❗ - Line 297, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 29, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 300, Col 25 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 302, Col 55 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 307, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 33, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 35, Col 24 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 37, Col 24 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 39, Col 24 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 41, Col 24 - Naming/VariableNumber - Use normalcase for variable numbers.
• ❗ - Line 43, Col 12 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 51, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 52, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 55, Col 27 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 60, Col 29 - Style/TrailingCommaInArguments - Avoid comma after the last parameter of a method call.
• ❗ - Line 64, Col 28 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
• ❗ - Line 75, Col 20 - Security/YAMLLoad - Prefer using YAML.safe_load over YAML.load.
• ❗ - Line 85, Col 20 - Security/YAMLLoad - Prefer using YAML.safe_load over YAML.load.