Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. #19949

h-kataria · 2020-03-11T13:53:57Z

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab.

Follow up PR for ManageIQ/manageiq-ui-classic#6730

UI PR: Configuration manager non explorer version manageiq-ui-classic#6782
Schema PR: Renamed foreman features to ems_configuration and adjusted roles manageiq-schema#464

before

after

db/fixtures/miq_product_features.yml

Fryguy · 2020-03-11T17:46:14Z

We're going to need a data migration for the user roles and the shortcuts if the identifier is changing.

h-kataria · 2020-03-25T23:53:08Z

We're going to need a data migration for the user roles and the shortcuts if the identifier is changing.

Since old screens are removed and new screens are added in UI, these are no longer renaming of existing features.

skateman · 2020-03-30T10:36:34Z

@h-kataria travis issue seems relevant (loading the features YAML fails)

skateman

db/fixtures/miq_user_roles.yml

bdunne · 2020-03-30T21:10:23Z

We're going to need a data migration for the user roles and the shortcuts if the identifier is changing.

Since old screens are removed and new screens are added in UI, these are no longer renaming of existing features.

I think Jason's concern is for any existing users that have permissions to old identifiers, those need to be migrated to use the new permissions, right?

skateman · 2020-04-01T10:19:13Z

I'm a little confused by the seeding vs migrations, let's say I have this migration:

  def up
    old_feature = MiqProductFeature.find_by(:identifier => 'provider_foreman_explorer').id
    new_features = MiqProductFeature.where(:identifier => %w[configuration_manager_show_list configuration_profile_show_list configured_system_show_list]).pluck(:id)

    old_assignments = MiqRolesFeature.where(:miq_product_feature_id => old_feature)

    old_assignments.each do |a|
      new_features.each do |f_id|
        MiqRolesFeature.create(:miq_product_feature_id => f_id, :miq_user_role_id => a.user_role_id)
      end
    end

    old_assignments.delete_all
  end

I am replacing all foreman_explorers with the 3 new features in all user roles. However, when the db:seed runs through, the old_feature will not be available. So my question is how to proceed @Fryguy @bdunne

Fryguy · 2020-04-01T12:52:19Z

Easiest thing is to just rename the existing feature in the migration as long as the features' parents are still the same and nothing else changes. Otherwise you will need to create the new features in the migration as well.

skateman

I found some problems while writing the migration, also I'd like to propose the name ems_configuration if that's possible.

db/fixtures/miq_product_features.yml

db/fixtures/miq_user_roles.yml

Testing ManageIQ/manageiq-ui-classic#6782, ManageIQ/manageiq#19949 and ManageIQ/manageiq-schema/ManageIQ#464

h-kataria · 2020-04-22T16:18:46Z

@h-kataria I don't see any cross-repo tests, unless I'm missing it. Can you create one?

Added cross-repo tests ManageIQ/manageiq-cross_repo-tests#113

Testing ManageIQ/manageiq-ui-classic#6782, ManageIQ/manageiq#19949 and ManageIQ/manageiq-schema#464

Fryguy · 2020-04-23T16:05:24Z

app/models/configured_system.rb

@@ -46,6 +46,8 @@ class ConfiguredSystem < ApplicationRecord
  scope :with_manager,                  ->(manager_id) { where(:manager_id => manager_id) }
  scope :with_configuration_profile_id, ->(profile_id) { where(:configuration_profile_id => profile_id) }
  scope :without_configuration_profile_id,          -> { where(:configuration_profile_id => nil) }
+  scope :not_ansible, -> { where.not(:type => ["ManageIQ::Providers::EmbeddedAnsible::AutomationManager::ConfiguredSystem",
+                                               "ManageIQ::Providers::AnsibleTower::AutomationManager::ConfiguredSystem"]) }


I really don't like this ☹️ ... ~~I'll merge for now but we need a different way to do this.~~

cc @bdunne @agrare

This should really be something describing "not from automation managers", but not calling out ansible. Or perhaps in the positive, "under configuration managers only"

I'm tempted to actually make this a blocker...we really can't be adding references to plugins in core. @agrare Is there a way to express this without resorting to type checks?

Why are we excluding AutomationManager::ConfiguredSystems ?

Yeah we can check if the ext_management_system is a ConfigurationManager

@Fryguy you might know a cleaner way of checking the type but something like this would do the trick:

scope :configuration_manager, -> { where(:manager => ManageIQ::Providers::ConfigurationManager.all) }

>> ConfiguredSystem.configuration_manager ConfiguredSystem Load (0.8ms) SELECT "configured_systems".* FROM "configured_systems" WHERE "configured_systems"."manager_id" IN (SELECT "ext_management_systems"."id" FROM "ext_management_systems" WHERE "ext_management_systems"."type" IN ('ManageIQ::Providers::ConfigurationManager', 'ManageIQ::Providers::Foreman::ConfigurationManager')) LIMIT $1 [["LIMIT", 11]] ConfiguredSystem Inst Including Associations (0.1ms - 1rows) => #<ActiveRecord::Relation [#<ConfiguredSystem id: 1, type: nil, hostname: nil, direct_operating_system_flavor_id: nil, configuration_profile_id: nil, manager_id: 7, manager_ref: nil, created_at: "2020-04-23 16:29:11", updated_at: "2020-04-23 16:29:11", last_checkin: nil, build_state: nil, configuration_location_id: nil, configuration_organization_id: nil, ipaddress: nil, mac_address: nil, ipmi_present: nil, puppet_status: nil, direct_customization_script_ptable_id: nil, direct_customization_script_medium_id: nil, operating_system_flavor_id: nil, customization_script_medium_id: nil, customization_script_ptable_id: nil, inventory_root_group_id: nil, virtual_instance_ref: nil, counterpart_type: nil, counterpart_id: nil>]>

Why are we excluding AutomationManager::ConfiguredSystems ?

Technically the configured_systems records include records from both ConfigurationManagers as well as AutomationManagers. When viewing the list from the Configuration -> Configured Systems we need to exclude them.

Now that I've written that out, that is EXACTLY what we do with Cloud instances/templates vs Infra vms/templates, so whatever we do there is exactly what we should do here. @h-kataria How do we do that differentiation for Cloud/Infra vms?

scope :configuration_manager, -> { where(:manager => ManageIQ::Providers::ConfigurationManager.all) }`

Minor, but I think I'd change that slightly to

scope :under_configuration_managers, -> { where(:manager => ManageIQ::Providers::ConfigurationManager.all) }`

Otherwise, :configuration_manager appears like a has_one relationship and would return a configuration_manager, but it doesn't

When viewing the list from the Configuration -> Configured Systems we need to exclude them.

That makes much more sense, we want to group them not exclude some

Minor, but I think I'd changed that slightly to

Oh yeah wasn't suggesting a name haha

Added named_scope to get Configuration Manager specific Configured System records. Ansible Configured systems are being displayed on Automation Manager explorer

Fryguy · 2020-04-28T20:51:01Z

locale/en.yml

@@ -781,9 +781,11 @@ en:
      ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript: Job Template (Ansible Tower)
      ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationWorkflow: Workflow Template (Ansible Tower)
      ManageIQ::Providers::AnsibleTower::AutomationManager::Playbook: Playbook (Ansible Tower)
+      ManageIQ::Providers::CloudAutomationManager::ConfigurationManager:    Configuration Manager (Cloud Automation Manager)


These are pluggable now that we have #20100 merged, so the provider plugins should bring their own dictionary entries. cc @agrare I think we should blast out these changes to all providers.

locale/en.yml

Fryguy · 2020-04-28T20:52:11Z

@h-kataria This PR looks good to me once we remove the dictionary entries.

These entries are no longer needed after merge of ManageIQ#20100

miq-bot · 2020-04-29T15:58:56Z

Checked commits h-kataria/manageiq@1a2ae17~...25bee8a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍰

simaishi · 2020-05-18T18:26:02Z

@h-kataria Backporting to jansa conflicts on db/fixtures/miq_product_features.yml. Can you please create a PR for jansa branch?

Renamed provider_foreman specific features, links etc to configuration_manager Jansa specific PR for backport of ManageIQ#19949

h-kataria · 2020-05-18T18:55:31Z

@simaishi created Jansa specific PR #20183

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. (cherry picked from commit 431bbe3)

simaishi · 2020-05-21T18:44:41Z

Jansa backport details:

$ git log -1
commit f8b58af7f4902716b571ce7dbe6805d2bdd9805c
Author: Jason Frey <[email protected]>
Date:   Thu May 7 22:05:54 2020 -0400

    Merge pull request #19949 from h-kataria/provider_foreman_renaming

    Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab.

    (cherry picked from commit 431bbe358c8f8858d6766619c697d5dbb497ca07)

These permissions where changed here: ManageIQ/manageiq#19949 and as such, the Ansible playbook results would not be displayed. Changing to use "service_view" permission since the manageiq-ui-classic uses "service" (level above), and this is only displaying the view, so this should be the only permission required.

h-kataria added enhancement wip providers/configuration labels Mar 11, 2020

h-kataria requested review from agrare and bdunne as code owners March 11, 2020 13:53

h-kataria mentioned this pull request Mar 11, 2020

Renaming of provider_foreman files, code to configuration_manager ManageIQ/manageiq-ui-classic#6756

Closed

bdunne reviewed Mar 11, 2020

View reviewed changes

db/fixtures/miq_product_features.yml Outdated Show resolved Hide resolved

bdunne reviewed Mar 11, 2020

View reviewed changes

db/fixtures/miq_product_features.yml Outdated Show resolved Hide resolved

chessbyte reviewed Mar 11, 2020

View reviewed changes

db/fixtures/miq_product_features.yml Outdated Show resolved Hide resolved

h-kataria force-pushed the provider_foreman_renaming branch from 77622f1 to 813b6ab Compare March 12, 2020 03:11

h-kataria removed the wip label Mar 12, 2020

h-kataria changed the title ~~[WIP] - Renamed provider_foreman to configuration_manager~~ Renamed provider_foreman to configuration_manager Mar 12, 2020

h-kataria force-pushed the provider_foreman_renaming branch 2 times, most recently from e4d4496 to 1d3d35e Compare March 20, 2020 22:15

chessbyte mentioned this pull request Mar 21, 2020

Support Pluggable Configuration Manager #19992

Closed

3 tasks

h-kataria requested review from Fryguy and gtanzillo as code owners March 24, 2020 22:04

h-kataria mentioned this pull request Mar 25, 2020

Configuration manager non explorer version ManageIQ/manageiq-ui-classic#6782

Merged

h-kataria changed the title ~~Renamed provider_foreman to configuration_manager~~ Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. Mar 25, 2020

h-kataria force-pushed the provider_foreman_renaming branch from f6ef583 to 0e201d3 Compare March 25, 2020 23:54

Fryguy assigned bdunne Mar 26, 2020

skateman approved these changes Mar 30, 2020

View reviewed changes

skateman reviewed Mar 30, 2020

View reviewed changes

db/fixtures/miq_user_roles.yml Outdated Show resolved Hide resolved

skateman suggested changes Apr 1, 2020

View reviewed changes

db/fixtures/miq_product_features.yml Outdated Show resolved Hide resolved

db/fixtures/miq_user_roles.yml Outdated Show resolved Hide resolved

h-kataria added a commit to h-kataria/manageiq-cross_repo-tests that referenced this pull request Apr 22, 2020

Cross repo test for foreman provider explorer conversion changes

183609b

Testing ManageIQ/manageiq-ui-classic#6782, ManageIQ/manageiq#19949 and ManageIQ/manageiq-schema/ManageIQ#464

h-kataria mentioned this pull request Apr 22, 2020

Cross repo test for foreman provider explorer conversion changes ManageIQ/manageiq-cross_repo-tests#113

Closed

h-kataria added a commit to h-kataria/manageiq-cross_repo-tests that referenced this pull request Apr 22, 2020

Cross repo test for foreman provider explorer conversion changes

6ac8d57

Testing ManageIQ/manageiq-ui-classic#6782, ManageIQ/manageiq#19949 and ManageIQ/manageiq-schema#464

Fryguy reviewed Apr 23, 2020

View reviewed changes

Added a named_scope to get Configuration Manager specific records

21d8260

Added named_scope to get Configuration Manager specific Configured System records. Ansible Configured systems are being displayed on Automation Manager explorer

h-kataria force-pushed the provider_foreman_renaming branch from 924044c to 21d8260 Compare April 23, 2020 20:00

Fryguy reviewed Apr 28, 2020

View reviewed changes

locale/en.yml Outdated Show resolved Hide resolved

Removed CAM entries that were added in previous commit

25bee8a

These entries are no longer needed after merge of ManageIQ#20100

Fryguy merged commit 431bbe3 into ManageIQ:master May 8, 2020

Fryguy added the jansa/yes? label May 8, 2020

gtanzillo added jansa/yes and removed jansa/yes? labels May 14, 2020

h-kataria added a commit to h-kataria/manageiq that referenced this pull request May 18, 2020

Renamed provider_foreman to configuration_manager

b8c60f8

Renamed provider_foreman specific features, links etc to configuration_manager Jansa specific PR for backport of ManageIQ#19949

h-kataria mentioned this pull request May 18, 2020

[JANSA] Renamed provider_foreman to configuration_manager #20183

Closed

gtanzillo added the jansa/conflict label May 21, 2020

simaishi pushed a commit that referenced this pull request May 21, 2020

Merge pull request #19949 from h-kataria/provider_foreman_renaming

f8b58af

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. (cherry picked from commit 431bbe3)

simaishi added jansa/backported and removed jansa/conflict labels May 21, 2020

h-kataria deleted the provider_foreman_renaming branch December 31, 2020 15:47

agrare mentioned this pull request May 12, 2021

Fix Provider create product feature ManageIQ/manageiq-api#1038

Merged

NickLaMuro mentioned this pull request Jul 30, 2021

Fix viewAnsible permissions ManageIQ/manageiq-ui-service#1705

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. #19949

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. #19949

h-kataria commented Mar 11, 2020 •

edited by Fryguy

Loading

Fryguy commented Mar 11, 2020 •

edited

Loading

h-kataria commented Mar 25, 2020

skateman commented Mar 30, 2020

skateman left a comment

bdunne commented Mar 30, 2020

skateman commented Apr 1, 2020

Fryguy commented Apr 1, 2020 •

edited

Loading

skateman left a comment

h-kataria commented Apr 22, 2020

Fryguy Apr 23, 2020 •

edited

Loading

agrare Apr 23, 2020

Fryguy Apr 23, 2020

Fryguy Apr 23, 2020

agrare Apr 23, 2020

agrare Apr 23, 2020

agrare Apr 23, 2020 •

edited

Loading

Fryguy Apr 23, 2020 •

edited

Loading

Fryguy Apr 23, 2020 •

edited

Loading

agrare Apr 23, 2020

Fryguy Apr 28, 2020

Fryguy commented Apr 28, 2020

miq-bot commented Apr 29, 2020

simaishi commented May 18, 2020

h-kataria commented May 18, 2020 •

edited

Loading

simaishi commented May 21, 2020

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. #19949

Removed provider_foreman explorer and added new non-explorer style screens under Configuration main tab. #19949

Conversation

h-kataria commented Mar 11, 2020 • edited by Fryguy Loading

Fryguy commented Mar 11, 2020 • edited Loading

h-kataria commented Mar 25, 2020

skateman commented Mar 30, 2020

skateman left a comment

Choose a reason for hiding this comment

bdunne commented Mar 30, 2020

skateman commented Apr 1, 2020

Fryguy commented Apr 1, 2020 • edited Loading

skateman left a comment

Choose a reason for hiding this comment

h-kataria commented Apr 22, 2020

Fryguy Apr 23, 2020 • edited Loading

Choose a reason for hiding this comment

agrare Apr 23, 2020

Choose a reason for hiding this comment

Fryguy Apr 23, 2020

Choose a reason for hiding this comment

Fryguy Apr 23, 2020

Choose a reason for hiding this comment

agrare Apr 23, 2020

Choose a reason for hiding this comment

agrare Apr 23, 2020

Choose a reason for hiding this comment

agrare Apr 23, 2020 • edited Loading

Choose a reason for hiding this comment

Fryguy Apr 23, 2020 • edited Loading

Choose a reason for hiding this comment

Fryguy Apr 23, 2020 • edited Loading

Choose a reason for hiding this comment

agrare Apr 23, 2020

Choose a reason for hiding this comment

Fryguy Apr 28, 2020

Choose a reason for hiding this comment

Fryguy commented Apr 28, 2020

miq-bot commented Apr 29, 2020

simaishi commented May 18, 2020

h-kataria commented May 18, 2020 • edited Loading

simaishi commented May 21, 2020

h-kataria commented Mar 11, 2020 •

edited by Fryguy

Loading

Fryguy commented Mar 11, 2020 •

edited

Loading

Fryguy commented Apr 1, 2020 •

edited

Loading

Fryguy Apr 23, 2020 •

edited

Loading

agrare Apr 23, 2020 •

edited

Loading

Fryguy Apr 23, 2020 •

edited

Loading

Fryguy Apr 23, 2020 •

edited

Loading

h-kataria commented May 18, 2020 •

edited

Loading